Add deployment config field to SagemakerEndpoint. - #318
Draft
cj-zhang wants to merge 2 commits into
Draft
Conversation
Piyush Jain (3coins)
left a comment
Piyush Jain (3coins)
left a comment
Collaborator
There was a problem hiding this comment.
cj-zhang
Thanks for submitting this change. A minor suggestion to use a model rather than dict to self validate the config.
| deployment_config: Optional[Dict] = None | ||
| """The deployment configuration for an undeployed endpoint or inference component | ||
| which can be deployed through the Sagemaker Python SDK ModelBuilder class. | ||
| Comprises two sub-dictionaries model_config and endpoint_config. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Comprises two sub-dictionaries model_config and endpoint_config. | |
| Comprises two sub-dictionaries model_config and endpoint_config. |
| .. _boto3: <https://boto3.amazonaws.com/v1/documentation/api/latest/index.html> | ||
| """ | ||
|
|
||
| deployment_config: Optional[Dict] = None |
Collaborator
There was a problem hiding this comment.
Rather than keeping this as an open-ended dictionary, how about encoding this as a pydantic model, with allowed additions.
|
|
||
| deployment_config: Optional[Dict] = None | ||
| """The deployment configuration for an undeployed endpoint or inference component | ||
| which can be deployed through the Sagemaker Python SDK ModelBuilder class. |
Collaborator
There was a problem hiding this comment.
Are the Model Builder SDK changes available to test this?
Collaborator
|
cj-zhang |
cj-zhang
marked this pull request as draft
January 16, 2025 19:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deployment_configfield onSagemakerEndpointto allow SageMaker model and compute definitions.