Skip to content

fix: don't panic on DF table provider if test has filter on indexed column - #3954

Merged
westonpace merged 2 commits into
lance-format:mainfrom
westonpace:feat/df-provider-context
Jun 13, 2025
Merged

westonpace merged 2 commits into
lance-format:mainfrom
westonpace:feat/df-provider-context

Conversation

@westonpace

Copy link
Copy Markdown
Member

We need to ensure all of our exec nodes do not spawn tasks in the execute fn until apache/datafusion#16312 is addressed. The AddRowAddrExec was violating this and this PR fixes that.

@codecov-commenter

codecov-commenter commented Jun 6, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.40%. Comparing base (fc3c8d4) to head (ce0a529).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/io/exec/rowids.rs 89.79% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3954      +/-   ##
==========================================
+ Coverage   78.35%   78.40%   +0.04%     
==========================================
  Files         285      285              
  Lines      110238   111457    +1219     
  Branches   110238   111457    +1219     
==========================================
+ Hits        86378    87385    +1007     
- Misses      20482    20683     +201     
- Partials     3378     3389      +11     
Flag Coverage Δ
unittests 78.40% <89.79%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@westonpace
westonpace merged commit b434ce9 into lance-format:main Jun 13, 2025
@renato2099

Copy link
Copy Markdown
Contributor

thanks for fixing this @westonpace !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-python Python bindings bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants