Skip to content

fix(ci): use a Maven Central mirror for CI downloads - #974

Open
majin1102 wants to merge 3 commits into
mainfrom
codex/fix-maven-cache-writer
Open

majin1102 wants to merge 3 commits into
mainfrom
codex/fix-maven-cache-writer

Conversation

@majin1102

@majin1102 majin1102 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

CI can fail before compilation or tests when Maven Central returns errors while downloading Maven, plugins, or dependencies. Earlier runs hit HTTP 429 for maven-source-plugin:2.2.1; a controlled cold-cache comparison also reproduced HTTP 404 and 429 while downloading Maven itself.

Configure the Google-hosted Maven Central mirror through setup-java's existing mvn-mirrors input. Set MVNW_REPOURL for the wrapper download, which happens before Maven reads settings.xml, following Trino's CI setup.

The final change adds 10 lines across the Spark, AWS, and Search workflows. Cache behavior, dependency versions, build commands, timeouts, and job parallelism are unchanged.

Validation

Controlled comparison: three repetitions of the 16 Spark workflow tasks per source, using the same application code (c0fbc96), runner type, JDK, commands, and timeouts. Each task used new Maven dependency and wrapper directories, with Maven cache restore/save disabled. All 96 cold-cache and source checks passed. Source pairs ran in one temporary workflow with at most 32 concurrent jobs; failed jobs were not rerun.

Repetition Original source: failed tasks Google mirror: failed tasks
1 5/16 0/16
2 1/16 0/16
3 1/16 0/16
Total 7/48 (14.6%) 0/48 (0%)

All seven failures occurred while downloading Maven 3.9.9: six HTTP 404 responses and one HTTP 429 response. Every other task passed; there were no test failures or timeouts. Thus all three original-source groups failed, while all three mirror groups passed.

This directly supports the wrapper source override. The comparison does not isolate the dependency/plugin mirror's independent benefit or establish a long-term failure rate. The experiment workflow is on a separate branch and is not part of this PR.

  • actionlint and git diff --check passed.
  • Local fresh-cache wrapper download, root install, Spark 3.5 / Scala 2.13 compilation, and 49 LanceSparkWriteOptionsTest cases passed.
  • The PR's Spark workflow passed all 16 jobs, and Search CI passed.

@github-actions github-actions Bot added the bug Something isn't working label Nov 19, 2026
@majin1102 majin1102 changed the title fix(ci): populate Maven cache from full builds fix(ci): use a Maven Central mirror for CI downloads Nov 19, 2026
@majin1102 majin1102 closed this Nov 19, 2026
@majin1102 majin1102 reopened this Nov 19, 2026
@majin1102
majin1102 marked this pull request as ready for review November 20, 2026 03:47

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T03:48:33.817201Z c0fbc96 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Gate recommendation: approve.

Using the wrapper override alongside Maven’s central mirror covers both bootstrap downloads and plugin/dependency resolution. The configuration stays within the three CI workflows and preserves their existing commands, matrices, caching, and permissions.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant