fix(core): clear the two clippy errors failing nightly verify - #1720
Merged
Merged
Conversation
`cargo clippy --workspace --all-targets -- -D warnings` has failed on main since 897a50f, so every Nightly verify run since 2026-09-05 is red while the PR CI stays green. Two lints in one test, both in `test_compiled_softcap_sdpa_gqa_decode_matches_repeated_reference`: an `f32 -> f32` cast on the `fill` closure's return, and `b * h_q * 1 * d` where the `1` is the decode q_len that the shape literal next to it already spells out. The element count and the test's numbers are unchanged. Validated: workspace clippy clean, `cargo fmt --all -- --check` clean, and the three `ffi_tests::test_compiled_softcap_sdpa_gqa*` tests pass.
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo clippy --workspace --all-targets -- -D warningshas failed on main since 897a50f. The PR gate stays green because it does not run that scope, so the only place this shows up is Nightly verify, which has been red every night since 2026-09-05 (runs 34262127778 and its four predecessors, all failing at the same two lines).Both lints are in
test_compiled_softcap_sdpa_gqa_decode_matches_repeated_reference: anf32 -> f32cast on thefillclosure's return value, andb * h_q * 1 * d, where the1is the decode q_len that the&[b, h_q, 1, d]shape literal on the same line already states. The element count is identical either way, so the test's inputs and expectations do not move; a comment keeps the q_len readable.Validated on M1 Ultra:
cargo clippy --workspace --all-targets --features metal,accelerate -- -D warningsclean,cargo fmt --all -- --checkclean, and the threeffi_tests::test_compiled_softcap_sdpa_gqa*tests pass.