Skip to content

feat(crd): [TKC-6839] add a cache block to a Test Workflow step - #8337

Closed
vsukhin wants to merge 1 commit into
vsukhin/cache/2-protofrom
vsukhin/cache/3-crd
Closed

vsukhin wants to merge 1 commit into
vsukhin/cache/2-protofrom
vsukhin/cache/3-crd

Conversation

@vsukhin

@vsukhin vsukhin commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

key, paths and restoreKeys are what a step declares; scope, workingDir and mount are the knobs around them. The scope enum is validated by the CRD, which is why it cannot be templated - enum validation runs before expressions are resolved.

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@vsukhin
vsukhin added this pull request to stack #8336 September 17, 2026 19:42
@vsukhin
vsukhin requested a review from a team as a code owner September 17, 2026 19:42
@vsukhin
vsukhin requested review from caiomede-tk and removed request for a team September 17, 2026 19:42
@testkubebot

testkubebot Bot commented Sep 17, 2026

Copy link
Copy Markdown

✅ Testkube GitHub Integration

Review based on commit 8e2c124.

All tests and quality gates passed.


Phase Status
Test Workflow Execution ✅ Passed
Quality Gate ✅ Passed

7 workflows executed

lint-go passed
in 4m56s (🚀 21. Sep. 2026 - 11:47:50 UTC / 🏁 21. Sep. 2026 - 11:52:46 UTC)

lint-proto passed
in 28s (🚀 21. Sep. 2026 - 11:47:50 UTC / 🏁 21. Sep. 2026 - 11:48:19 UTC)

integration-tests passed
in 7m47s (🚀 21. Sep. 2026 - 11:47:50 UTC / 🏁 21. Sep. 2026 - 11:55:37 UTC)

unit-tests passed
in 4m34s (🚀 21. Sep. 2026 - 11:47:50 UTC / 🏁 21. Sep. 2026 - 11:52:25 UTC)

verify-crds passed
in 2m3s (🚀 21. Sep. 2026 - 11:47:50 UTC / 🏁 21. Sep. 2026 - 11:49:53 UTC)

verify-protobuf passed
in 33s (🚀 21. Sep. 2026 - 11:47:50 UTC / 🏁 21. Sep. 2026 - 11:48:24 UTC)

lint-pr passed
in 31s (🚀 21. Sep. 2026 - 11:47:50 UTC / 🏁 21. Sep. 2026 - 11:48:22 UTC)


Manage this Integration

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The CRD contract change appears safe to merge, with its generated Kubernetes and Helm artifacts consistently synchronized.

Summary

This PR adds the TestWorkflow step cache API model, including cache keys, fallback keys, paths, scope, working-directory, and mount controls. It also consistently regenerates the deepcopy implementation, standalone CRDs, and all canonical and vendored Helm CRD schemas. No merge-blocking issue was identified.

Reviews (1) · Last reviewed commit: "feat(crd): add a cache block to a Test W..."

@vsukhin

vsukhin commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

@testkube

@vsukhin vsukhin changed the title feat(crd): add a cache block to a Test Workflow step feat(crd): [TKC-6839] add a cache block to a Test Workflow step Sep 18, 2026
@vsukhin
vsukhin force-pushed the vsukhin/cache/3-crd branch from 9e777b8 to e887531 Compare September 18, 2026 11:28
key, paths and restoreKeys are what a step declares; scope, workingDir and
mount are the knobs around them. The scope enum is validated by the CRD, which
is why it cannot be templated - enum validation runs before expressions are
resolved.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vsukhin
vsukhin force-pushed the vsukhin/cache/3-crd branch from e887531 to 8e2c124 Compare September 21, 2026 11:46
@vsukhin vsukhin closed this Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant