Repository navigation
build: switch inspektor-gadget fork from matthyx to kubescape #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # inspektor-gadget fork | ||
|
|
||
| node-agent depends on a fork of `inspektor-gadget/inspektor-gadget` via a `replace` | ||
| directive in `go.mod`, instead of the upstream module, because node-agent needs | ||
| changes (e.g. eBPF map manual-fetch triggers, syscall map handling) before they land | ||
| upstream. | ||
|
|
||
| ## Current fork | ||
|
|
||
| The fork is **`github.com/kubescape/inspektor-gadget`**, pinned to a specific commit | ||
| via a pseudo-version: | ||
|
|
||
| ``` | ||
| replace github.com/inspektor-gadget/inspektor-gadget => github.com/kubescape/inspektor-gadget v0.0.0-<timestamp>-<short-sha> | ||
| ``` | ||
|
|
||
| This is an org-owned fork of `inspektor-gadget/inspektor-gadget`, kept as a plain | ||
| mirror of whatever commit node-agent currently needs — it is not meant to diverge | ||
| with its own history. Previously this pointed at a personal fork | ||
| (`matthyx/inspektor-gadget`); that was migrated to the org fork so the dependency | ||
| isn't tied to one contributor's personal account. | ||
|
|
||
| ## Updating the pin | ||
|
|
||
| 1. Push (or force-push) the desired commit to `kubescape/inspektor-gadget:main`. | ||
| 2. Update the `replace` line in `go.mod` with the new commit's pseudo-version: | ||
| ``` | ||
| go get github.com/inspektor-gadget/inspektor-gadget@<commit-sha> | ||
| ``` | ||
| 3. Run `go mod tidy` and `go build ./...` to confirm `go.sum` and the build are consistent. | ||
|
|
||
| The pin is a point-in-time snapshot, not a tracking reference — moving | ||
| `kubescape/inspektor-gadget:main` further does not update `go.mod` automatically. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
✅ Runtime observed
🏁 Script executed:
Repository: kubescape/node-agent
Length of output: 324
🏁 Script executed:
Repository: kubescape/node-agent
Length of output: 4943
Use the fork path when resolving the commit.
go get github.com/inspektor-gadget/inspektor-gadget@06b0d12baca0e2ba61df1aa5a00dc9e449567a10fails withinvalid version: unknown revisionbecause the commit is not in the upstream repository. Usegithub.life-white.uk/kubescape/inspektor-gadgetwhen resolving the commit, then verify thereplacedirective withgo mod tidyandgo build ./....🤖 Prompt for AI Agents