Repository navigation
Conversation
|
Summary:
|
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
|
Summary:
|
matthyx
marked this pull request as ready for review
May 24, 2024 10:31
|
Summary:
|
dwertent
approved these changes
May 26, 2024
| } | ||
|
|
||
| func (rm *RelevancyManager) HasRelevancyCalculating(pod *v1.Pod) bool { | ||
| for _, c := range pod.Status.ContainerStatuses { |
There was a problem hiding this comment.
InitContainers and ephemeral containers
| ReportNetworkEvent(k8sContainerID string, event tracernetworktype.Event) | ||
| ReportDNSEvent(event tracerdnstype.Event) | ||
| ReportRandomxEvent(k8sContainerID string, event tracerrandomxtype.Event) | ||
| HasApplicableRuleBindings(namespace, name string) bool |
There was a problem hiding this comment.
I'm not sure why these functions are related to the RuleManager interface
| for _, pod := range n.k8sObjectCache.GetPods() { | ||
| var app string | ||
| if pod.Labels != nil { | ||
| app = pod.Labels["app"] |
There was a problem hiding this comment.
What if this label is empty? Consider looking at the app.kubernetes.io/name label as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.