Repository navigation
feat: make the shared image pull secret configurable - #703
Open
Matthiator wants to merge 1 commit into
Open
Matthiator wants to merge 1 commit into
Matthiator wants to merge 1 commit into
Conversation
2 of 3 tasks
tuunit
force-pushed
the
optional-image-pull-secret
branch
from
November 10, 2026 20:12
bdf7ed6 to
1ae0212
Compare
tuunit
reviewed
Nov 10, 2026
tuunit
left a comment
tuunit
left a comment
Contributor
There was a problem hiding this comment.
@Matthiator I just merged the refactor for libkubara introducing kubebuilder and controller-runtime as building blocks for the kubara internals therefore your open PR was full of conflicts. I fixed it and changed your implementation to adhere to the new way of defining types.
Further we want to introduce a global config or options field to the clusters which would probably be the better place for your new field to live. Therefore I'll keep the PR open for another 2 weeks or so
tuunit
reviewed
Nov 11, 2026
| Networking ClusterNetworking `json:"networking,omitempty"` | ||
|
|
||
| // Image Pull Secret Name,description=Shared registry secret name. | ||
| // +kubebuilder:validation:Pattern=`^$|^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$` |
Contributor
There was a problem hiding this comment.
Wouldn't this be just fine?
Suggested change
| // +kubebuilder:validation:Pattern=`^$|^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$` | |
| // +kubebuilder:validation:Pattern=`^$|^[-a-z0-9]{1,63}$` |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some projects do not want a shared image pull secret distributed to every namespace, or simply have no registry credentials to configure.
Add
clusters[].imagePullSecretName: empty disables the shared pull secret, a name overrides it, and omission preservesimage-pull-secret. Bootstrap and local OpenBao respect the setting; docs explain optional credentials.Change type
Breaking change
How I tested it
go test ./internal/config ./internal/cmd/bootstrap ./internal/envconfig ./internal/cmd/generatemkdocs build --strict; no live bootstrap tested.Notes for reviewers
Companion catalogs: kubara-io/catalogs#290 (required to omit generated references). Existing configurations retain their default behavior.