Complete after a closer outside the value it ended - #445
Merged
Merged
Conversation
A key or empty line after a closing `}`, `]` or `>`, an end-dot or an end-dash completed inside the value it closed rather than where the parser puts the key. A span includes its end, so the closer's start found the container's last value instead of the container. A caret past a closer now resolves from the closer's end, which finds the container itself. Hover and definition in whitespace after a closer likewise resolve to the closed value, not its last child.
dmarcotte
approved these changes
Sep 30, 2026
dmarcotte
left a comment
dmarcotte
left a comment
Contributor
There was a problem hiding this comment.
Thanks @holodorum! Looks great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A key or empty line after a closing
},]or>, an end-dot or an end-dash completed inside the value it closed rather than where the parser puts the key. A span includes its end, so the closer's start found the container's last value instead of the container.A caret past a closer now resolves from the closer's end, which finds the container itself. Hover and definition in whitespace after a closer likewise resolve to the closed value, not its last child.