Repository navigation
feat(T13884): pass CLEO_HOOK_PROVIDER to the goal tick - #2361
Merged
Merged
Conversation
runTickKillable takes the dispatcher's --provider and spawns the tick with CLEO_HOOK_PROVIDER set to it, the rest of the environment inherited. The name is GOAL_TICK_PROVIDER_ENV in @cleocode/contracts/goal-runtime.js so cleo-goal can import it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleo hook stop --provider <claude-code|codex>now spawns the goal tick withCLEO_HOOK_PROVIDER=<provider>added to the inherited environment. That letscleo-goal ticktell which harness's Stop it is answering.runTickKillable(command, input, timeoutMs, provider?): when a provider is given, it sets the variable and leaves everything else inprocess.envas it was.processStopDispatchDepspasses the dispatcher's provider through.GOAL_TICK_PROVIDER_ENVin@cleocode/contracts/goal-runtime.js, so cleo-goal can import it. It is a const in a types-only module, so gate 10 passes.stop-dispatch-entry.test.ts: a real tick child reportsCLEO_HOOK_PROVIDERfor both providers, andHOMEis unchanged.Verification
The owner directive is no local heavy runs, so CI verifies the tests and typecheck.
--check), 10, 25, 38, 40 and 32 (--base origin/main) pass. CI enforces gate 39.🤖 Generated with Claude Code