Let user control fallback to original babel sql exection function - #80
Conversation
| (and (cdr (assq :engine params)) | ||
| (not | ||
| (yes-or-no-p | ||
| (concat "ejc-sql is enabled, ignore source block :engine parameters\n" |
There was a problem hiding this comment.
Actually, I'd prefer my version of the message here since a user have to pass a set of params to execute queries.
:engine - is only one of it. Furthermore, \n is redundant here. I split code for 2 lines to improve readability.
(concat "ejc-sql is enabled, ignore source block connection"
" parameters and use ejc-sql to execute it? ")Or probably this version (see: https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-sql.html):
(concat "ejc-sql is enabled, ignore source block connection"
" header arguments and use ejc-sql to execute it? ")
|
|
||
| ### Mix ejc-sql with Org Mode default ob-sql engine together in one buffer | ||
|
|
||
| You can set option `ejc-org-mode-babel-wrapper` to disable `ejc-sql` wrapper |
There was a problem hiding this comment.
It's too descriptive (no need to dig into details). Keep the header and place a text like this:
You can use both ejc-sql and original org-babel execution simultaneously.
To disable ejc-sql wrapper around Org Mode SQL source code blocks, set ejc-org-mode-babel-wrapper to nil (enabled by default).
If ejc-org-mode-babel-wrapper is enabled and the current SQL source code block has a connection header arguments, you will be asked for confirmation.
|
Updated now, thanks for your advise. and sorry for my clumsy description. :) |
1 similar comment
|
Updated now, thanks for your advise. and sorry for my clumsy description. :) |
|
Thank you. Merged. |
3 participants
Reference to original PR #74