refactor(aws): compare the lambda package type with the SDK constant - #1184
Merged
Merged
Conversation
mbevc1
added
tech-investment
and removed
go
Contributor
|
Claude encountered an error after 1m 31s —— View job Follow-up review complete
Result: Both previous findings are resolved by commit
No new issues found in the changed lines. Full details posted as a summary comment and two resolved inline replies. |
mbevc1
enabled auto-merge (squash)
September 15, 2026 09:00
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
mbevc1
disabled auto-merge
September 15, 2026 09:03
A minor bump of a generated AWS client is additive: new model fields and new enum values. A comparison against a raw string literal does not move with the SDK. Lambda's package type is a real SDK enum (lambda/types.PackageType), but getAndProcessOneLambdaFunc flattened it with string() so that processOneLambdaFunc could compare it to "Zip". Keep the typed value all the way down and compare it to types.PackageTypeZip. ECS has no equivalent: it models Task.lastStatus as a plain string, and ecsTypes.DesiredStatus is the status a task is heading for, not the one it last reported. Leave that comparison on the literal, reading the field through aws.ToString rather than dereferencing a pointer AWS need not have set.
processOneLambdaFunc's callers dereferenced LastModified, CodeSha256 and FunctionName directly, even though all three are optional *string fields on GetFunctionConfigurationOutput. A missing one panics the whole snapshot goroutine instead of surfacing as an error; a missing LastModified now degrades into formatLambdaLastModified's existing parse error, which the caller already handles. Also assert LastModifiedTimestamp in TestProcessOneLambdaFunc instead of only the digest, deriving the expectation the same way TestFormatLambdaLastModified does.
mbevc1
force-pushed
the
20260915_fix_types
branch
from
September 15, 2026 09:07
8fba57e to
f815ef4
Compare
mbevc1
enabled auto-merge (squash)
September 15, 2026 09:08
Contributor
Follow-up review — commit f815ef4Both previous findings on
No new issues found in the changed lines ( |
AlexKantor87
approved these changes
Sep 15, 2026
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
kosli-cli 2.41.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre># New features - Added `kosli attest sbom` command (beta) to report a software bill of materials (CycloneDX JSON/XML or SPDX JSON/tag-value) to an artifact or trail in a Kosli flow. The SBOM file checksum, format, and a parsed summary are recorded; `sbom_format` and `sbom_sha256` are automatically added as annotations. - Added hidden `--server-side` flag to trail evaluation commands, enabling server-side policy evaluation (experimental, not yet a stable contract). <!-- Release notes generated using configuration in .github/release.yml at v2.41.0 --> ## What's Changed * feat(sbom): read CycloneDX and SPDX bills of materials by @AlexKantor87 in kosli-dev/cli#1165 * feat(attest-sbom): add kosli attest sbom by @AlexKantor87 in kosli-dev/cli#1168 * fix(sonar): never send the API token to a redirect target by @mbevc1 in kosli-dev/cli#1170 * fix(snapshot azure): reject zip entries that would extract outside the temp dir by @mbevc1 in kosli-dev/cli#1175 * fix(sbom): read the tool from a CycloneDX services entry by @AlexKantor87 in kosli-dev/cli#1179 * fix(snapshot azure): stop a container spoofing its digest in logs mode by @mbevc1 in kosli-dev/cli#1176 * chore: improve PR follwo-up reviews by @mbevc1 in kosli-dev/cli#1181 * feat(evaluate): evaluate a trail server-side behind a hidden flag by @jumboduck in kosli-dev/cli#1171 * fix: align review turns by @mbevc1 in kosli-dev/cli#1185 * refactor(aws): compare the lambda package type with the SDK constant by @mbevc1 in kosli-dev/cli#1184 **Full Changelog**: kosli-dev/cli@v2.40.1...v2.41.0 </pre> <p>View the full release notes at <a href="https://github.com/kosli-dev/cli/releases/tag/v2.41.0">https://github.com/kosli-dev/cli/releases/tag/v2.41.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!20275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick testing fixes from #1176
Checklist
charts/k8s-reporter/) updated, if needed. Note: these changes live in a separate PR