fix(docs): help typos - #1142
Conversation
|
Claude finished @mbevc1's task in 1m 39s —— View job Review — PR #1142
|
| Check | Result |
|---|---|
go build ./... |
✅ pass |
go vet ./... |
✅ pass |
go mod tidy + git diff --exit-code go.mod go.sum |
✅ clean |
Changes reviewed
cmd/kosli/attestSonar.go (long help text, lines 42 & 51) — both overriden → overridden. Correct: override is a two-syllable-stress verb, so the past participle doubles the d.
cmd/kosli/root.go:300 — overriden → overridden, and sonar scanner → Sonar scanner. Thanks for picking up the follow-up nit; sonarWorkingDirFlag now matches the Sonar scanner casing used throughout attestSonar.go, so the flag help and the command long-help read consistently.
Verification
- Grepped the whole repo (not just
.go) foroverriden— zero remaining occurrences. Also checked a handful of adjacent common misspellings (occured,seperate,recieve,dependant,paramater,existance,compatable) — all clean. - Checked
testdata/for golden files containing this help text: the only hit iscmd/kosli/testdata/empty-flag-audit-coverage.json:467, which stores the flag name ("sonar-working-dir"), not its description. No golden files need regenerating. - No generated CLI docs are checked into the repo (
docs/holds only ADRs and handover notes), so the docs checklist item is satisfied by the help-text edit itself.
Nits / risks
None. Nothing to flag on quality, edge cases, bugs, security, or performance — the diff touches only string literals used for help output.
Nice work
Small, focused, single-purpose diff that's trivially reviewable — exactly the "thin vertical slice" shape CLAUDE.md asks for. Also good that you fixed all three occurrences of the same misspelling in one pass rather than leaving the codebase half-corrected, and took the consistency nit on the line you were already touching.
· branch 20260830_fix_typos
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
kosli-cli 2.39.2 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre># Improvements - Fixed typos in help text for `attest sonar` command (corrected "overriden" to "overridden") and the `--sonar-working-dir` flag description. <!-- Release notes generated using configuration in .github/release.yml at v2.39.2 --> ## What's Changed * fix(docs): help typos by @mbevc1 in kosli-dev/cli#1142 * ci(release): generate the full changelog, including What's Changed list by @mbevc1 in kosli-dev/cli#1143 **Full Changelog**: kosli-dev/cli@v2.39.1...v2.39.2 </pre> <p>View the full release notes at <a href="https://github.com/kosli-dev/cli/releases/tag/v2.39.2">https://github.com/kosli-dev/cli/releases/tag/v2.39.2</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!18343
Minor typo fixes.
Checklist
charts/k8s-reporter/) updated, if needed. Note: these changes live in a separate PR