Conversation
Compute (TagsInput) and vpc (ChipsInput) each built a free-text tags field because TagSelect only picks from a fixed list and has no label, error or helper text. TagsInput mirrors the Input API (label, isRequired, error, helperText, labelAction), adds tags on Enter or comma, removes the last one with Backspace on an empty field, commits the pending text on blur, and offers `suggestions` in a keyboard-navigable listbox with a loading state.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compute (
TagsInput) and vpc (ChipsInput) each built a free-text tags field becauseTagSelectonly selects from a fixed list and exposes no label, error or helper text.TagsInput(new): controlledvalue: string[]/onChange. Enter or comma (delimiters) adds the trimmed, de-duplicated tag; Backspace on an empty field removes the last one; each tag is a dismissibleBadge. The pending text is committed on blur (commitOnBlur).suggestionsshows the unselected matches in a listbox with ArrowUp/ArrowDown/Enter/Escape and mouse selection;isLoadingshows a spinner and a loading row. Mirrors theInputAPI:label,isRequired,labelAction,error,helperText,aria-invalid/aria-describedby,disabled.Test plan
commitOnBlur=false, error/helper description, loading + disabled, axenpx vitest run lib/components/TagsInput, lint, types, prettierTagsInput