Skip to content

fix: Add newline after qr code and print usage if incorrect number of args passed - #48

Open
ssnover wants to merge 3 commits into
kennytm:masterfrom
ssnover:fix/qrencode-bin-ui
Open

ssnover wants to merge 3 commits into
kennytm:masterfrom
ssnover:fix/qrencode-bin-ui

Conversation

@ssnover

@ssnover ssnover commented Apr 20, 2021 •

Copy link
Copy Markdown

Closes issue #47 and adds a newline following print out of QR code to stdout.

@ssnover ssnover changed the title fix: Add newline after qr code and print usage if incorrect number of… fix: Add newline after qr code and print usage if incorrect number of args passed Apr 20, 2021
@coveralls

coveralls commented Apr 20, 2021 •

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 93.603% when pulling c48cb06 on ssnover:fix/qrencode-bin-ui into faa4397 on kennytm:master.

@ssnover

ssnover commented Apr 20, 2021

Copy link
Copy Markdown
Author

@kennytm The code coverage analysis seems too sensitive. It seems like there should be a set coverage target (say 90%) and the coverage of a given PR should be compared with the target. Having it fail on any decrease seems like too much.

I'm not familiar with kcov, but it seems you are given that you authored the cargo component. Is there a means of accomplishing what I described and would you be interested in that for this project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants