Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A handler registered through the hero/MVC container that returns a
nilvalue does not run the configured result handler chain.UseResultHandlerhandlers are silently skipped for nil returns:Fixes #2534
Root cause
In
hero/func_result.go,dispatchCommononly invokes the result handler chain when the value is non-nil:So when a handler returns nil,
customstays nil and theUseResultHandlerchain never runs.Fix
When the container has custom result handlers registered, run the handler chain even for a nil value — a nil return is a legitimate case a custom handler may want to observe or replace. Behavior without custom handlers is unchanged: the default handler is still not invoked on nil, so nil returns keep flushing headers/content exactly as before. The flag is threaded from the call site (
len(c.resultHandlers) > 0);Response.Dispatchpassesfalse.Tests
Added
TestContainerUseResultHandlerOnNil: a handler returningnilwith a registeredUseResultHandlernow runs the handler (which replaces the nil result), and the response reflects the replacement. Verified it fails before the change ("result handler was not called for a nil return value") and passes after. Fullherosuite passes;gofmtandgo vetclean.