Skip to content

fix: ignore local cache directories in go docker context - #1978

Merged
EItanya merged 1 commit into
mainfrom
fix-dockerignore-local-cache
Jun 8, 2026
Merged

EItanya merged 1 commit into
mainfrom
fix-dockerignore-local-cache

Conversation

@EItanya

@EItanya EItanya commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Ignore local .cache directories in the Go Docker build context
  • Prevent agent/tool-created Go caches from invalidating Docker COPY layers

Verification

  • Ran make build-controller DOCKER_BUILD_ARGS='--progress=plain --platform linux/amd64 --output type=cacheonly' twice
  • Confirmed the second run reused cached Dockerfile layers, including the Go compile step

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Copilot AI review requested due to automatic review settings June 8, 2026 13:27
@EItanya
EItanya requested review from ilackarms and yuval-k as code owners June 8, 2026 13:27
@github-actions github-actions Bot added the bug Something isn't working label Jun 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go module’s Docker build context exclusions to prevent locally generated .cache directories from invalidating Docker COPY layers and forcing unnecessary rebuilds.

Changes:

  • Add ignore patterns for .cache/ directories to go/.dockerignore.
  • Minor formatting normalization for the Makefile entry in go/.dockerignore.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@EItanya
EItanya merged commit 37cc7d5 into main Jun 8, 2026
25 checks passed
@EItanya
EItanya deleted the fix-dockerignore-local-cache branch June 8, 2026 15:04
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
kagent 0.9.7

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre><!-- Release notes generated using configuration in .github/release.yml at v0.9.7 -->

## What's Changed
### Features
* feat(api): add workingDir to BYO agent deployment spec by @mesutoezdil in kagent-dev/kagent#1970
* feat(ui): add guard to prevent out-of-sync sends when working cross-tabs by @onematchfox in kagent-dev/kagent#1904
### Bug Fixes
* fix(controller): disable standalone SSE for STREAMABLE_HTTP remote mcp servers by @jmhbh in kagent-dev/kagent#1974
* fix: ignore local cache directories in go docker context by @EItanya in kagent-dev/kagent#1978
* fix(controller): return error instead of panicking on unknown auth mode by @SarthakB11 in kagent-dev/kagent#1791
### Other Changes
* Expose the controller's /metrics endpoint through a dedicated Service by @danielorbach in kagent-dev/kagent#1803
* Migrate from A2A v0 to v1 (part 1) by @supreme-gg-gg in kagent-dev/kagent#1921
* switch from tags to digest for images by @peterj in kagent-dev/kagent#1961
* automatically refresh substrate status page by @peterj in kagent-dev/kagent#1990
* chore: bump kagent tools to 0.2.1 by @jmhbh in kagent-dev/kagent#1995
* support running declarative agents in substrate by @peterj in kagent-dev/kagent#1981


**Full Changelog**: https://github.com/kagent-dev/kagent/compare/v0.9.6...v0.9.7</pre>
  <p>View the full release notes at <a href="https://github.com/kagent-dev/kagent/releases/tag/v0.9.7">https://github.com/kagent-dev/kagent/releases/tag/v0.9.7</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!11305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants