Skip to content

.pxd files not included in PyDAS installation #11

Description

@jwallen

The .pxd files should be installed alongside the compiled modules in order to allow users to easily compile and link Cython modules against PyDAS.

The .pyx files could also be installed in order to provide another way for users to find the source.

Activity

  1. jwallen commented on Feb 12, 2015

    @jwallen
    OwnerAuthor

    The best I've been able to do so far is to get all Python-like files in the root project directory to install by adding the parameter packages=[''] to the setup() call. This grabs all the files we'd want, but also grabs the test files, which I'd rather not have. I'd suggest at least moving the test scripts into a test subdirectory.

    The packages=[''] syntax is kind of odd, and seems like it could have unexpected side effects. Therefore it might also make sense to move things into a pydas package, e.g. pydas.dassl and pydas.daspk modules instead of pydas and pydaspk. This would give more intuitive naming, but would require everyone to update their code. Feedback would be welcome on this.

    @rwest: Once this is working we can remove the unsightly pydas.pxd file from the RMG-Py root directory.

  2. rwest commented on Feb 12, 2015

    @rwest
    Contributor

    pydas.dassl and pydas.daspk (and pydas.thenextthing) sounds better to me than pydas (being dassl) and pydaspk (being daspk). I'd be OK with a change that requires code updates in other projects. Especially if there's a way to flag it with a version number bump or something, and a note somewhere obvious about what the required changes are. It would be a bit annoying breaking backwards compatibility though, for example if different topic branches of RMG-Py switch over at different times...

  3. added a commit that references this issue on Feb 14, 2015
    1cb2cb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions