Skip to content

Cleanup + Rust Module Build test - #12

Merged
jroesch merged 7 commits into
jroesch:fix-for-thermlfrom
hypercubestart:rust_fix
Feb 4, 2021
Merged

jroesch merged 7 commits into
jroesch:fix-for-thermlfrom
hypercubestart:rust_fix

Conversation

@hypercubestart

Copy link
Copy Markdown

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.

@hypercubestart

hypercubestart commented Jan 6, 2021 •

Copy link
Copy Markdown
Author

I've traced the segfault to this line in the rust code:

let imported_mod = import_python(py, "tvm")?;

It seems like there is a test for this but its ignored

#[ignore]
#[test]
fn test_run() -> Result<()> {
load_python_tvm_(Python::acquire_gil().python()).unwrap();
Ok(())
}

@jroesch
jroesch merged commit 44c738b into jroesch:fix-for-therml Feb 4, 2021
@hypercubestart
hypercubestart deleted the rust_fix branch February 9, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants