Repository navigation
just a test PR - #245
just a test PR#245glehmann wants to merge 3 commits into
Conversation
The checkPRs polling loop in AppShell called getPREnrichment and fetchInvolvedPRs without error handling. When the GitHub API was unreachable, the promise rejection was unhandled (fire-and-forget), producing an 'Uncaught (in promise) HttpError: NetworkError'. Wrapped the polling body in try/catch so transient network failures are silently ignored and polling continues on the next interval.
b9c621c to
97d3aaa
Compare
Two bugs fixed in app-shell.tsx: 1. handleTabSelect called markTabUpdated instead of clearTabUpdated when clicking a tab (despite the comment saying 'Clear updated flag'). This caused the ⟳ to flash briefly when selecting a tab. 2. The updated indicator was a solid orange dot (bg-orange-500). Changed to orange ⟳ with transparent background.
97d3aaa to
f9a1167
Compare
|
just a test comment |
|
Another comment |
|
And another one |
|
and again |
|
and again another one! |
|
still testing commments |
| default-src 'self'; | ||
| connect-src 'self' https://api.github.com; | ||
| img-src 'self' https://github.com https://avatars.githubusercontent.com https://private-user-images.githubusercontent.com https://camo.githubusercontent.com data:; | ||
| media-src 'self' https://private-user-images.githubusercontent.com; |
There was a problem hiding this comment.
an inline comment
| (t): t is Tab & { owner: string; repo: string; number: number } => | ||
| t.type === "pr-review" && | ||
| t.owner !== undefined && | ||
| t.repo !== undefined && |
There was a problem hiding this comment.
another in-line comment
| if (baseline && enrichment.updatedAt > baseline) { | ||
| markTabUpdated(tab.id); | ||
| try { | ||
| const prTabs = tabs.filter( |
There was a problem hiding this comment.
Test comment inline, should appear as a review comment.
| [navigate, clearTabUpdated] | ||
| ); | ||
|
|
||
| // Close a tab and navigate to the next active tab if needed |
There was a problem hiding this comment.
This comment was originally on lines 137-141 of src/browser/components/app-shell.tsx, which is outside the diff — GitHub's API can only anchor review comments to diff lines, so it was moved to the nearest one.
A comment outside of a modified region
| @@ -528,13 +532,15 @@ function TabStatusIndicator({ status }: { status?: TabStatus }) { | |||
| ); | |||
There was a problem hiding this comment.
This comment was originally on lines 413-415 of src/browser/components/app-shell.tsx, which is outside the diff — GitHub's API can only anchor review comments to diff lines, so it was moved to the nearest one.
Remove those lines
|
pulldash/src/browser/components/app-shell.tsx Lines 300 to 302 in f9a1167 |
There was a problem hiding this comment.
An out-of-diff comment
pulldash/src/browser/components/app-shell.tsx
Lines 11 to 14 in f9a1167
There was a problem hiding this comment.
another out-of-diff comment
pulldash/src/browser/components/app-shell.tsx
Lines 18 to 20 in f9a1167
No description provided.