Require constructor parameters to avoid temporal coupling #97

Activity

1. jeevatkm commented on Apr 15, 2019

   

   jeevatkm

   on Apr 15, 2019

   Owner

   More actions

   @janoszen I think currently supported has validations for the required parameters. If I misunderstood your suggestion, could you please provide some code snippet to explain the idea?
3. jeevatkm commented on Apr 17, 2019

   

   jeevatkm

   on Apr 17, 2019

   Owner

   More actions

   @janoszen Thank you for sharing your suggestion. It is helpful to define a constructor in the respective POJOs. I'm not sure when I can get to this suggestion; there are feature(s) should be added is in pending state.

   FYI, the library already has validations in almost all methods I believe, for example -

   digitalocean-api-java/src/main/java/com/myjeeva/digitalocean/impl/DigitalOceanClient.java

   Lines 300 to 307 in 479d227

   	public Droplet createDroplet(Droplet droplet)
   	throws DigitalOceanException, RequestUnsuccessfulException {
   	if (null == droplet || StringUtils.isBlank(droplet.getName()) || null == droplet.getRegion()
   	|| null == droplet.getSize() || (null == droplet.getImage()
   	|| (null == droplet.getImage().getId() && null == droplet.getImage().getSlug()))) {
   	throw new IllegalArgumentException(
   	"Missing required parameters [Name, Region Slug, Size Slug, Image Id/Slug] for create droplet.");
   	}