fix(zsh): stop the completion-init handler from breaking file completion for other commands

[jdx]

https://entire.io/gh/jdx/usage/trails/42

With source <(usage g completion-init zsh) in .zshrc, completing a command that is not a usage script falls back to _files. The fallback ran after the handler's own emulate -L zsh, which replaced the options zsh's completion system sets for every completer. _files got nullglob and rcexpandparam turned off. #692 papered over the resulting no matches found error with setopt nonomatch, and #712 reports what happened next: with the glob error suppressed, _path_files could offer its own pattern, so emacs --<TAB> inserted a literal *.

The handler now leaves options alone until it knows the command is a usage script. emulate -L zsh moved into that branch, which returns before _files is reached. Commands that are not usage scripts get _files with the same options any other completer sees. Completion for usage scripts is unchanged.

Anyone who sources the init script picks this up on the next shell start. Completion files generated by usage g completion zsh <bin> never call _files and are unaffected.

Validation. test_zsh_completion_init_integration now calls the handler under $_comp_options, the way _main_complete does, and asserts that the _files stub sees nullglob, rcexpandparam and extendedglob on. Against the old template it fails with nullglob=off rcexpandparam=off. I couldn't reproduce the literal * in a zpty session on zsh 5.9 with default zstyles, so the test checks the option state that causes the symptom, not the symptom itself.

Fixes #712

🤖 Generated with Claude Code

---

Note

Low Risk
Scoped change to generated zsh init completion script and its integration test; per-bin zsh completions are unchanged.

Overview
Fixes broken file completion for non–usage-shebang commands when usage g completion-init zsh is sourced. The default handler no longer runs emulate -L zsh and setopt nonomatch extendedglob at entry; those resets only run on the branch that completes a usage script, so _files keeps the completion system’s options (nullglob, rcexpandparam, extendedglob) and avoids regressions like literal * candidates (#712).

test_zsh_completion_init_integration now drives the handler through a complete wrapper that applies $_comp_options (like _main_complete) and asserts the _files stub sees those options enabled.

^{Reviewed by Cursor Bugbot for commit 2f1645d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• Bug Fixes
  • Fixed zsh completion for usage-shebang scripts so file completions preserve the shell’s existing options. This prevents unintended glob patterns from appearing as completion candidates and keeps results consistent with the active completion settings.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 09d9bd49-3eb5-4244-be17-7ce335e7c86e

📥 Commits

Reviewing files that changed from the base of the PR and between c73dd39 and 2f1645d.

⛔ Files ignored due to path filters (1)

• lib/src/complete/snapshots/usage__complete__zsh__tests__complete_zsh_init.snap is excluded by !**/*.snap

📒 Files selected for processing (2)

• cli/tests/shell_completions_integration.rs
• lib/src/complete/zsh.rs

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The zsh completion handler now preserves the completion system’s options when it falls back to _files. It applies emulate -L zsh on the usage-shebang path. The integration test exercises the handler with completion options and checks the options seen by _files.

Changes

Zsh completion fallback

Layer / File(s)	Summary
Preserve completion options in fallback lib/src/complete/zsh.rs, cli/tests/shell_completions_integration.rs	The handler applies emulate -L zsh only on the usage-shebang path, leaving the existing options in place for the _files fallback. The integration test runs the handler with completion options and checks that _files sees nullglob, rcexpandparam, and extendedglob enabled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: jambalaya56562

Merge Risk: ⚪ Minimal · up to 2f164

No actionable merge-blocking risk remains from the reviewed changes.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: preventing the zsh completion-init handler from disrupting file completion for other commands.
Linked Issues check	✅ Passed	The change satisfies the coding requirement in [#712]. emulate -L zsh now runs only on the usage-script completion path. The ordinary-command fallback reaches _files without resetting the completi…
Out of Scope Changes check	✅ Passed	The pull request changes only the zsh completion implementation and its integration regression test. Both changes directly support [#712]. The summary identifies no unrelated behavior or files. Genera…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge; no actionable regression was identified.

Summary

The PR preserves zsh’s completion-system options when the init handler falls back to file completion, while retaining option emulation for usage-script completion.

• Updates the generated init snapshot.
• Tests that the fallback sees nullglob, rcexpandparam, and extendedglob enabled.

_{Reviews (1) · Last reviewed commit: "fix(zsh): keep the completion system's o..."}

[github-actions]

Instruction counts

The comparison never ran — an earlier step failed.

_{2f1645d6f1e7 vs `` · measured on the runner, not pushed to the history.}