CI: add a build against numpy nightly - #129
Merged
Merged
Conversation
jakevdp
force-pushed
the
ci-numpy-nightly
branch
from
December 13, 2023 17:23
89884fd to
18b2637
Compare
Collaborator
Author
|
CI failure should be fixed by numpy/numpy#25389 |
jakevdp
force-pushed
the
ci-numpy-nightly
branch
2 times, most recently
from
December 13, 2023 17:44
42b9edd to
39edf7f
Compare
Collaborator
Author
|
Looks like failures are due to pybind11 not being compatible with numpy 2.0. We need a release with pybind/pybind11#4857 (2.11.1 is currently the most recent release, and does not include this change). |
jakevdp
force-pushed
the
ci-numpy-nightly
branch
8 times, most recently
from
December 19, 2023 23:49
e3e3996 to
3993f56
Compare
Collaborator
Author
|
Finally hit a real failure! numpy/numpy#25292 removed |
jakevdp
force-pushed
the
ci-numpy-nightly
branch
from
December 20, 2023 00:04
099a61e to
ec3bd5c
Compare
jakevdp
force-pushed
the
ci-numpy-nightly
branch
2 times, most recently
from
December 20, 2023 00:43
96f50c0 to
bfa7f3b
Compare
jakevdp
force-pushed
the
ci-numpy-nightly
branch
4 times, most recently
from
December 20, 2023 17:12
5c99d88 to
e5bd04f
Compare
hawkinsp
reviewed
Dec 20, 2023
jakevdp
force-pushed
the
ci-numpy-nightly
branch
2 times, most recently
from
December 20, 2023 17:19
e5da001 to
818a50f
Compare
hawkinsp
approved these changes
Dec 20, 2023
jakevdp
force-pushed
the
ci-numpy-nightly
branch
from
December 20, 2023 17:30
818a50f to
54ffcfe
Compare
jakevdp
force-pushed
the
ci-numpy-nightly
branch
from
December 20, 2023 17:54
54ffcfe to
6632fdb
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is failing, because upstream numpy removedPyArray_TypeNumFromNamelast week (numpy/numpy#25292). This is a real failure that we'd like this test to catch. When I commented-out that part of the source code, tests passed.I propose we merge this as-is, and then work to fix the failure by using an alternative API.Fixed in the second commit on the branch.