Repository navigation
refactor(kv-indexer): make the cuckoo module root the DC relay contract - #206
Draft
ishandhanani wants to merge 1 commit into
Draft
ishandhanani wants to merge 1 commit into
ishandhanani wants to merge 1 commit into
Conversation
The cuckoo module's root re-export list is now the relay contract: every item the pool relay in lib/llm and the relay benches name, plus every type that appears in the signature of one of those items (`-W unnameable_types` is clean). The submodules were already private; the `pub use adapter::*` glob is gone, as are the three DEFAULT_GLOBAL_INGESTION_* constants nothing outside the module reads. Items reachable at the module root: 60 before, 50 after. `cuckoo/adapter.rs` (LocalCkfAdapter and its six error and report types, 547 lines) had no user anywhere in the tree once the glob was gone; it is deleted along with its README row. The ingestion pool names its sibling `global` module directly instead of going through the root list. The pre-split `dynamo_kv_router::indexer::cuckoo` compat block (182 lines, 60 re-exports and deprecated aliases) is removed; `dynamo_kv_indexer::cuckoo` is the only path. The kv-indexer host.rs header and AGENTS.md state the contract. Part of DYNO-197 Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
ishandhanani
had a problem deploying
to
external_collaborator
November 11, 2026 04:07 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
cuckoomodule ofdynamo-kv-indexeris the DC relay's pool index. Its consumers are the pool relay inlib/llmand the relay benches inlib/bench; the indexer stage itself does not use it. This change makes the module's root re-export list the relay contract and removes everything that is not part of it.-W unnameable_types). Submodules were already private, so an item off the list is unreachable.pub use adapter::*is gone.cuckoo/adapter.rs(LocalCkfAdapterand six error and report types, 547 lines) had no user anywhere in the tree, so it is deleted along with its README row.DEFAULT_GLOBAL_INGESTION_*constants leave the root; nothing outside the module reads them.globalmodule directly instead of through the root list.dynamo_kv_router::indexer::cuckoocompat block (182 lines, 60 re-exports and deprecated aliases) is removed.dynamo_kv_indexer::cuckoois the only path.host.rsheader andAGENTS.mdstate the contract in one sentence each.dynamo_kv_indexer::cuckoo::indexer::cuckooExported:
CKF_LANE_COUNT,CkfBuildError,CkfConfig,PrefixSearchConfig,CanonicalSequenceBlockHash,CkfCommitState,CkfFailureAction,CkfFailureDisposition,CkfFailureDomain,CkfFailurePoint,ConsumerDrainMarker,ConsumerInstanceId,DcCkfAggregationStats,DcCkfBucketImage,DcCkfDelta,DcCkfDeltaSink,DcCkfEventOutcome,DcCkfFormatIdentity,DcCkfMemoryStats,DcCkfPublicationBatch,DcCkfPublicationStats,DcCkfPublishError,DcCkfPublisher,DcCkfRankReplacement,DcCkfSnapshot,DcCkfState,DcCkfStats,GlobalCkfAssignmentError,GlobalCkfBucketImage,GlobalCkfBuildError,GlobalCkfDelta,GlobalCkfIndexer,GlobalCkfIngestOutcome,GlobalCkfIngestionError,GlobalCkfIngestionFault,GlobalCkfIngestionPool,GlobalCkfIngestionPoolBuildError,GlobalCkfIngestionPoolConfig,GlobalCkfLaneFault,GlobalCkfLaneIngestor,GlobalCkfLaneMatch,GlobalCkfManifest,GlobalCkfQueryError,GlobalCkfQueryResult,GlobalCkfSnapshot,LaneLease,ProducerIdentity,PublisherEmitOutcome,PublisherFenceReason,PublisherSnapshotError.Part of DYNO-197.
Validation
All with a fresh per-worktree target directory on top of
origin/main909d4ef.cargo fmt --all: clean.cargo check --workspace --all-targets --locked: one error, pre-existing onmainand untouched by this change:lib/llm/tests/streaming_tool_dispatch_http.rs:87is missingmodel_eos(fix(frontend): stop tool_call_dispatch handing harnesses truncated arguments ai-dynamo/dynamo#13986 vs fix(beam): finalize constrained tool calls at confirmed model EOS ai-dynamo/dynamo#17625).cargo check --workspace --lib --bins --tests --benches --examples --locked --exclude dynamo-llm: clean.cargo test -p dynamo-kv-indexer --locked: 594 passed, 2 ignored.cargo test -p dynamo-kv-router --locked: 138 + 2 passed.--all-features: 251 + 2 + 7 passed.cargo test -p dynamo-llm --lib pool_relay --locked: 269 passed.cargo clippy --no-deps --all-targets --locked -- -D warnings: clean fordynamo-kv-indexer,dynamo-kv-router,dynamo-kv-router --all-features. Fordynamo-llm,--all-targetshits the same pre-existingmodel_eosbreak;--lib --binsis clean.cd lib/bindings/python && cargo check --locked: clean.bash scripts/router_layering_check.sh: 36 checks, 0 failures.uvx pre-commit run --files <changed files>: no failed hooks.#![warn(unnameable_types)]on the module: zero warnings with the final list.