Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: angular
thetaPC
marked this pull request as ready for review
July 17, 2026 17:20
thetaPC
requested review from
brandyscarney and
gnbm
and removed request for
gnbm
July 17, 2026 17:20
brandyscarney
approved these changes
Jul 17, 2026
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Looks good! I just had a few suggested changes to some comments but nothing blocking. Tested out the dev build and the deprecation warning looks nice.
Comment on lines
+48
to
+50
| * `IonicModule` is deprecated and will be removed in a future major version. | ||
| * Use `provideIonicAngular()` from `@ionic/angular` instead. The deprecation is | ||
| * declared on the class itself, so consumers importing it here see the notice. |
Member
There was a problem hiding this comment.
Do we need this comment here? Should it just be a TODO() with the ticket to remove it later?
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
@ionic/angularships a module-based (lazy) build whose entry point isIonicModule. NgModule apps register Ionic by importingIonicModuleand callingIonicModule.forRoot(). Even though standalone components withprovideIonicAngular()are the default and recommended path in Ionic 9,IonicModulegives no signal that it is on its way out.What is the new behavior?
IonicModuleandIonicModule.forRoot()with@deprecatedJSDoc that points developers toprovideIonicAngular().IonicModule.forRoot()at bootstrap.BREAKING.md.README.mdand the in repo Angular testing docs.Does this introduce a breaking change?
Deprecating
IonicModuledoes not affect its functionality. Existing apps continue to work with no changes after upgrading. Full removal is planned for a future major version and is documented inBREAKING.md.Other information
Dev build:
8.8.14-dev.11784243422.11f0110c