Fix(nodes): color correct invocation - #8605
Merged
psychedelicious merged 15 commits intoOct 9, 2025
Merged
Conversation
Co-authored-by: dunkeroni <3298737+dunkeroni@users.noreply.github.com>
Co-authored-by: dunkeroni <3298737+dunkeroni@users.noreply.github.com>
Co-authored-by: dunkeroni <3298737+dunkeroni@users.noreply.github.com>
Co-authored-by: dunkeroni <3298737+dunkeroni@users.noreply.github.com>
…nding Co-authored-by: dunkeroni <3298737+dunkeroni@users.noreply.github.com>
…erting mask Co-authored-by: dunkeroni <3298737+dunkeroni@users.noreply.github.com>
dunkeroni
requested review from
blessedcoolant,
hipsterusername,
maryhipp and
psychedelicious
as code owners
October 9, 2025 05:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Existing ColorCorrectInvocation does not work. It triggers an error if no mask is provided, and when a mask is provided the result is an imagechops.mulitply of the mask and the two inputs, not outputting any actual corrected region.
Refactored node has the following changes:
Color space options will depend on use case. Since channels are corrected independently, the output can have combinations across multiple channels that do not appear in the inputs. This is a bigger issue in RGB, hence the option for YCbCr. From testing a few scenarios, RGB seems to do better when decreasing saturation/contrast, and YCbCr does better when restoring it.
Related Issues / Discussions
Closes #4770
Relevant discussions and mentions of broken node:
https://discord.com/channels/1020123559063990373/1130288930319761428/1424817011204292618
https://discord.com/channels/1020123559063990373/1345587047229816832/1422940609295159504
https://discord.com/channels/1020123559063990373/1178755835162267658/1178755835162267658
QA Instructions
Applied corrections for each colorspace option across multiple degradation methods and resolution combinations.
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)