fix(collectd): secure PMT expression evaluation - #276
Open
jaywsk wants to merge 2 commits into
Open
Conversation
Replace eval-based transformation handling with a restricted AST evaluator. Allow only required arithmetic and bitwise operations, and enforce limits on expression complexity and numeric computation. Signed-off-by: Jedrzej Wasiukiewicz <jedrzej.wasiukiewicz@intel.com>
Prevalidate transformation expressions during XML parsing and evaluate them using direct parameter lookup, avoiding repeated parsing and string substitution while preserving sandbox restrictions. Signed-off-by: Jedrzej Wasiukiewicz <jedrzej.wasiukiewicz@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace eval-based transformation handling with a restricted AST evaluator. Allow only required arithmetic and bitwise operations, and enforce limits on expression complexity and numeric computation.