chore(otlp-exporter): added missing resource mapping - #2684
Merged
Conversation
aryamohanan
force-pushed
the
chore-resource-mapping
branch
from
July 30, 2026 03:32
6faf92e to
2d579be
Compare
aryamohanan
commented
Jul 30, 2026
| /** @type {any} */ | ||
| this._compiledSemConv = null; | ||
| /** @type {string | null} */ | ||
| this._hostId = null; |
Contributor
Author
There was a problem hiding this comment.
_hostId is not set from anywhere to the context so remove d from here
aryamohanan
commented
Jul 30, 2026
aryamohanan
commented
Jul 30, 2026
| * @param {Record<string, any>} from | ||
| * @returns {string} | ||
| */ | ||
| function getResourceKey(from) { |
Contributor
Author
There was a problem hiding this comment.
This was used only on test file, removed
aryamohanan
commented
Jul 30, 2026
aryamohanan
commented
Jul 30, 2026
| /** | ||
| * @param {string} nodePlatform | ||
| */ | ||
| function normalizeOsType(nodePlatform) { |
Contributor
Author
There was a problem hiding this comment.
kirrg001
reviewed
Jul 30, 2026
kirrg001
reviewed
Jul 30, 2026
aryamohanan
changed the title
aryamohanan
force-pushed
the
chore-resource-mapping
branch
from
July 30, 2026 09:45
0ad3f58 to
b5d5deb
Compare
|
aryamohanan
changed the base branch from
feat-oltp-exporter
to
feat-otlp-exporter
July 30, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some resource mapping were not added earlier, added those.
Whats not included
Faas resource mapping can be handlied in a different PR
Future:
There are some rc candidates(not added in the tracer spec), can be extended later
Tracer spec: https://github.ibm.com/instana/technical-documentation/blob/master/tracing/specification/otlp-exporter.md#resource-attribute-mapping
otel spec https://opentelemetry.io/docs/specs/semconv/resource/
ref https://jsw.ibm.com/browse/INSTA-100980