feat(preproc): input file oriented preprocssing - #4062
Open
awildturtok wants to merge 2 commits into
Open
awildturtok wants to merge 2 commits into
awildturtok wants to merge 2 commits into
Conversation
awildturtok
changed the base branch from
develop
to
feature/preprocess-performance
October 1, 2026 08:19
awildturtok
commented
Oct 1, 2026
|
|
||
| final File preprocessedFile = preprocessingJob.getPreprocessedFile(); | ||
| TableImportDescriptor descriptor = preprocessingJob.getDescriptor(); | ||
| private void process(String[] row, ConqueryConfig config) { |
Collaborator
Author
There was a problem hiding this comment.
bind the config as a field in JobContext
Collaborator
Author
There was a problem hiding this comment.
rename to processRow
| final TableInputDescriptor input = descriptor.getInputs()[inputSource]; | ||
| final File sourceFile = resolveSourceFile(input.getSourceFile(), preprocessingJob.getCsvDirectory(), preprocessingJob.getTag()); | ||
| private void logErrors() { | ||
| if (errors > 0) { |
Collaborator
Author
There was a problem hiding this comment.
invert + return
| /** | ||
| * Apply one descriptor's transformations and write its CQPP output. | ||
| */ | ||
| public static void preprocess(PreprocessingJob job, ProgressBar totalProgress, ConqueryConfig config, int buckets) throws IOException { |
Collaborator
Author
There was a problem hiding this comment.
uinify by calling List-based overload and passing in singleton List
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.