refactor(frontend): fine-tuning and cleanup after the design-system prep - #4009
Merged
Conversation
Kadrian
marked this pull request as draft
September 3, 2026 21:21
Kadrian
force-pushed
the
refactor/toggle-button-group
branch
2 times, most recently
from
September 9, 2026 08:53
7083992 to
dd627f8
Compare
Kadrian
marked this pull request as ready for review
September 9, 2026 09:05
Kadrian
force-pushed
the
refactor/toggle-button-group
branch
from
September 9, 2026 09:11
82442e1 to
eaf4736
Compare
Kadrian
force-pushed
the
refactor/toggle-button-group
branch
from
September 9, 2026 09:38
eaf4736 to
82442e1
Compare
thoniTUB
approved these changes
Sep 9, 2026
…nted look for the mode switches
… VerticalToggleButton deleted
Kadrian
force-pushed
the
refactor/toggle-button-group
branch
from
September 10, 2026 12:27
82442e1 to
d0d474e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-system prep, step 9: fine-tuning and cleanup
Stacked on #4008. The smaller follow-ups after the button work.
ui-components/ToggleButtonGroupis react-aria's ToggleButtonGroup holding ourToggleButtons:selectionModesingle or multiple,selectedKeys/onSelectionChange,disallowEmptySelection, the arrow keys move along the group, each button keyed byid;sizeon the group applies to every buttonsegmentedjoins the buttons into one bordered control: the four mode switches (range/exact, OR/AND, the row prefix, the secondary id) are segmentedsmgroups, the selected segment is white with bold primary text, the secondary id options show their description as a tooltip