fix: async queries also uses HttpCompletionOption.ResponseHeadersRead - #649
Merged
Conversation
bednar
changed the title
HttpCompletionOption.ResponseHeadersRead
bednar
changed the title
HttpCompletionOption.ResponseHeadersReadHttpCompletionOption.ResponseHeadersRead
6 tasks
bednar
marked this pull request as ready for review
July 22, 2024 04:45
karel-rehor
approved these changes
Jul 22, 2024
karel-rehor
left a comment
karel-rehor
left a comment
Contributor
There was a problem hiding this comment.
Tests pass locally. Changes make sense.
latte-gh
pushed a commit
to dotnetcore/mocha
that referenced
this pull request
Aug 6, 2026
Updated [InfluxDB.Client](https://github.com/influxdata/influxdb-client-csharp) from 4.16.0 to 5.1.0. <details> <summary>Release notes</summary> _Sourced from [InfluxDB.Client's releases](https://github.com/influxdata/influxdb-client-csharp/releases)._ ## 5.1.0 ### CI 1. [#712](influxdata/influxdb-client-csharp#721): Update dotnet-5.0 image from "mcr.microsoft.com/dotnet/sdk:5.0" to "mcr.microsoft.com/dotnet/sdk:5.0-bullseye-slim". 1. [#724](influxdata/influxdb-client-csharp#724): Set snapshot version properly in ci-deploy-snapshot.sh 1. [#728](influxdata/influxdb-client-csharp#728): Set up auto merge dependabot workflow. 1. [#738](influxdata/influxdb-client-csharp#738): The token in the Management API is no longer plain text. 1. [#748](influxdata/influxdb-client-csharp#748): Set prefix commit message for dependabot. ----- ## What's Changed * ci: update dotnet-5.0 image by @NguyenHoangSon96 in influxdata/influxdb-client-csharp#721 * ci: set snapshot properly for deploy preview by @NguyenHoangSon96 in influxdata/influxdb-client-csharp#724 * chore(deps): Update RestSharp to 113.1.0 and use Timeout property by @drocx in influxdata/influxdb-client-csharp#719 * docs(Client.Legacy): correct 'occured' -> 'occurred' in README example by @SAY-5 in influxdata/influxdb-client-csharp#725 * ci: set up auto-merge dependabot by @NguyenHoangSon96 in influxdata/influxdb-client-csharp#728 * chore(deps): Bump Microsoft.Extensions.ObjectPool from 9.0.0 to 9.0.4 by @dependabot[bot] in influxdata/influxdb-client-csharp#716 * chore(deps): Bump System.Collections.Immutable from 9.0.1 to 9.0.4 by @dependabot[bot] in influxdata/influxdb-client-csharp#715 * chore(deps): Bump Radzen.Blazor from 5.7.2 to 6.6.4 by @dependabot[bot] in influxdata/influxdb-client-csharp#713 * chore(deps): Bump coverlet.collector from 6.0.3 to 6.0.4 by @dependabot[bot] in influxdata/influxdb-client-csharp#697 * chore(deps): Bump WireMock.Net from 1.6.11 to 1.7.1 by @dependabot[bot] in influxdata/influxdb-client-csharp#699 * chore(deps): Bump NodaTime from 3.2.0 to 3.2.2 by @dependabot[bot] in influxdata/influxdb-client-csharp#710 * chore(deps): Bump Tomlyn.Signed from 0.18.0 to 0.19.0 by @dependabot[bot] in influxdata/influxdb-client-csharp#711 * chore(deps): Bump System.Configuration.ConfigurationManager from 9.0.0 to 9.0.4 by @dependabot[bot] in influxdata/influxdb-client-csharp#714 * test: refactor token test by @NguyenHoangSon96 in influxdata/influxdb-client-csharp#738 * Bump coverlet.collector from 6.0.4 to 10.0.0 by @dependabot[bot] in influxdata/influxdb-client-csharp#729 * Bump CsvHelper from 33.0.1 to 33.1.0 by @dependabot[bot] in influxdata/influxdb-client-csharp#730 * Bump NodaTime from 3.2.2 to 3.3.2 by @dependabot[bot] in influxdata/influxdb-client-csharp#736 * Bump Microsoft.NET.Test.Sdk from 17.12.0 to 17.13.0 by @dependabot[bot] in influxdata/influxdb-client-csharp#733 * Bump Microsoft.Net.Http.Headers from 2.3.0 to 2.3.9 by @dependabot[bot] in influxdata/influxdb-client-csharp#732 * Bump Newtonsoft.Json from 13.0.3 to 13.0.4 by @dependabot[bot] in influxdata/influxdb-client-csharp#735 * Bump Moq from 4.20.69 to 4.20.72 by @dependabot[bot] in influxdata/influxdb-client-csharp#734 * ci: set prefix commit message dependabot by @NguyenHoangSon96 in influxdata/influxdb-client-csharp#748 * chore(deps): Bump Radzen.Blazor from 6.6.4 to 10.4.0 by @dependabot[bot] in influxdata/influxdb-client-csharp#749 * chore(deps): Bump Tomlyn.Signed from 0.19.0 to 2.4.0 by @dependabot[bot] in influxdata/influxdb-client-csharp#750 * chore(deps): Bump coverlet.collector from 10.0.0 to 10.0.1 by @dependabot[bot] in influxdata/influxdb-client-csharp#753 * chore(deps): Bump Microsoft.Net.Http.Headers from 2.3.9 to 2.3.10 by @dependabot[bot] in influxdata/influxdb-client-csharp#755 * chore(deps): Bump Microsoft.Extensions.ObjectPool from 9.0.4 to 10.0.8 by @dependabot[bot] in influxdata/influxdb-client-csharp#754 * chore(deps): Bump Radzen.Blazor from 10.4.0 to 10.4.3 by @dependabot[bot] in influxdata/influxdb-client-csharp#756 * chore(deps): Bump System.Collections.Immutable from 9.0.4 to 10.0.8 by @dependabot[bot] in influxdata/influxdb-client-csharp#757 * chore(deps): Bump System.Configuration.ConfigurationManager from 9.0.4 to 10.0.8 by @dependabot[bot] in influxdata/influxdb-client-csharp#758 * chore(deps): Bump Radzen.Blazor from 10.4.3 to 10.4.6 by @dependabot[bot] in influxdata/influxdb-client-csharp#761 * chore(deps): Bump WireMock.Net from 1.7.1 to 1.25.0 by @dependabot[bot] in influxdata/influxdb-client-csharp#763 * chore(deps): Bump Tomlyn.Signed from 2.4.0 to 2.4.1 by @dependabot[bot] in influxdata/influxdb-client-csharp#762 * chore: upgrade NUnit3TestAdapter by @NguyenHoangSon96 in influxdata/influxdb-client-csharp#764 * ci: fix codecov upload script by @NguyenHoangSon96 in influxdata/influxdb-client-csharp#765 ## New Contributors * @NguyenHoangSon96 made their first contribution in influxdata/influxdb-client-csharp#721 * @drocx made their first contribution in influxdata/influxdb-client-csharp#719 * @SAY-5 made their first contribution in influxdata/influxdb-client-csharp#725 ... (truncated) ## 5.0.0 ### Dependencies⚠️ Important Notice: Starting from this release, we won’t be listing every dependency change in our changelog. This helps us maintain the project faster and focus on important features for our InfluxDB client. ### Features 1. [#615](influxdata/influxdb-client-csharp#615): Use IEnumerable in WriteApi to eliminate unnescessary memmory allocations ### CI 1. [#681](influxdata/influxdb-client-csharp#681): Add build for `dotnet8` ## 4.18.0 ### Features: 1. [#658](influxdata/influxdb-client-csharp#658): Add HttpHeaders as `IEnumerable<RestSharp.HttpParameter>` to `HttpException` and facilitate access in `WriteErrorEvent`. Includes new example `HttpErrorHandling`. ### Dependencies Update dependencies: #### Build: - [#659](influxdata/influxdb-client-csharp#659): `RestSharp` to `112.0.0` #### Test: - [#663](influxdata/influxdb-client-csharp#663): `WireMock.Net` to `1.6.1` ## 4.17.0 [2024-08-12] ## 4.17.0 ### Breaking Changes #### API - `ApiResponse` headers has been changed to `IEnumerable<(string Name, string Value)>` ### Bug Fixes 1. [#649](influxdata/influxdb-client-csharp#649): Use HttpCompletionOption.ResponseHeadersRead for asynchronous QueryApi ### Dependencies Update dependencies: #### Build: - [#650](influxdata/influxdb-client-csharp#650): `RestSharp` to `111.4.0` - [#655](influxdata/influxdb-client-csharp#655): `Microsoft.Extensions.ObjectPool` to `8.0.7` #### Test: - [#652](influxdata/influxdb-client-csharp#652): `NUnit3TestAdapter` to `4.6.0` - [#654](influxdata/influxdb-client-csharp#654): `WireMock.Net` to `1.5.62` #### Examples: - [#657](influxdata/influxdb-client-csharp#657): `Radzen.Blazor` to `5.0.6` Commits viewable in [compare view](influxdata/influxdb-client-csharp@v4.16.0...v5.1.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #632 (comment)
Proposed Changes
Use
HttpCompletionOption.ResponseHeadersReadalso for async queries for possibility to use large queries then 2GiB.Checklist
dotnet testcompletes successfully