Repository navigation
Conversation
onUnmounted never runs during server rendering, so each render left a handler (and its page props) on the shared http client. Fixes inertiaui#284.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284.
ModalRootregisters its request interceptor during setup and removes it inonUnmounted, which never runs during server rendering. Every SSR render therefore left a handler, and the page props it closes over, on the sharedhttpclient.This skips the registration when
windowis undefined. It stays in setup rather than moving toonMounted, because the interceptor has to be in place before Inertia 3 loads deferred props.The new
tests/ModalRoot.ssr.test.jsrendersModalRootwithrenderToStringin a Node environment; it fails without the change.🤖 Generated with Claude Code