Repository navigation
Conversation
Rua
marked this pull request as draft
September 2, 2026 13:27
Rua
force-pushed
the
exprcontext-decl
branch
3 times, most recently
from
September 4, 2026 15:35
9f13e26 to
f2c82a3
Compare
Rua
marked this pull request as ready for review
September 4, 2026 15:35
Rua
marked this pull request as draft
September 4, 2026 16:05
Rua
force-pushed
the
exprcontext-decl
branch
2 times, most recently
from
September 7, 2026 18:32
e51a7f7 to
aa81e3b
Compare
Rua
force-pushed
the
exprcontext-decl
branch
from
September 22, 2026 11:48
aa81e3b to
58ffc59
Compare
Rua
force-pushed
the
exprcontext-decl
branch
2 times, most recently
from
October 2, 2026 10:30
110d8d6 to
4c0cbd0
Compare
ExprContext to most declscontext.rs module and split ExprContext into multiple types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
used()flag #1975Some context flags don't apply to all possible child nodes, so the split avoids accidentally passing/inheriting them when not needed. That helps deal with #1973 (comment), though there are further changes that are needed after this, to "reset" the
ExprContextspecific flags for each subexpression.The reason that
needs_addressgot renamed is mainly for easier naming of the new getter functions. If getters for booleans are to be namedis_*, thenis_needs_addressdoesn't work very well, whileis_address_neededworks much better. Thedecay_refflag was left public because it's going to be removed by #1982 anyway, so there's no point in investing extra time thinking of a way to make it fit the rest of the refactor.