Skip to content

Remove feature gate on the std feature - #213

Merged
fintelia merged 1 commit into
image-rs:masterfrom
paolobarbolini:std
Jan 7, 2022
Merged

fintelia merged 1 commit into
image-rs:masterfrom
paolobarbolini:std

Conversation

@paolobarbolini

@paolobarbolini paolobarbolini commented Jan 7, 2022 •

Copy link
Copy Markdown
Contributor

This improves the decode performance to up to 40%. Am I missing something? I wouldn't expect something this simple to add such a big change 😅.
The feature gate was added by #196, but no std feature is present in the Cargo.toml, so the multithreaded worker would never get used.

@paolobarbolini

Copy link
Copy Markdown
Contributor Author

Force pushed to change email

@fintelia

fintelia commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

The alternative would be to add the std feature to Cargo.toml, but I think your way is a better option seeing as #196 points out that the crate cannot actually work without the standard library.

@paolobarbolini

Copy link
Copy Markdown
Contributor Author

The alternative would be to add the std feature to Cargo.toml, but I think your way is a better option seeing as #196 points out that the crate cannot actually work without the standard library.

It could be added in 0.3.0

@fintelia
fintelia merged commit 55a4a9a into image-rs:master Jan 7, 2022
wartmanm pushed a commit to wartmanm/jpeg-decoder that referenced this pull request Sep 15, 2022
Remove feature gate on the std feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants