Repository navigation
fix(chrome-ext): open media actions in top-level popup - #613
Open
opaksbyron wants to merge 1 commit into
Open
opaksbyron wants to merge 1 commit into
opaksbyron wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sso-login-completechrome.windows.createwithsetSelfAsOpenerso the media popup is not blocked after a cross-origin iframe message and can report status to the side panelWhy
Chrome cannot reliably surface microphone or display-capture prompts from the storage-partitioned cross-origin mentor iframe inside an extension side panel. The mentor app already supports routing those actions to its host, but the extension did not enable that path. Opening the authenticated mentor route as a top-level popup lets Chrome present the normal media permission UI without adding an invalid manifest
microphonepermission.Testing
pnpm test— 448 files passed, 12,181 tests passed, 1 skippedpnpm buildpnpm typecheckpnpm lint:checkpnpm vitest run components/chat/__tests__/index.test.tsx -t "iframe and chat popup actions|welcome screen popup actions"The repository local pre-push review command could not run because the external
claudeCLI is not installed in this environment; all project-owned executable checks above passed.Manual verification
The final microphone/display chooser touch test requires loading the unpacked MV3 extension in Chrome native side-panel UI. This environment-specific checkpoint is recorded as not reproducible in the shared Playwright journey registry; URL/configuration behavior is regression-tested under Vitest.
Fixes #431