Make popups work on layer shells and fix incorrect cast - #114
Merged
Conversation
This corrects a unsound reinterpret cast from an IWaylandWindow to a CWaylandWindow. Calling get popup on a layer would cause this incorrect cast.
vaxerski
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the parent window type of popups to be
IWaylandWindownotCWaylandWindow. The parent was already set by casting anIWaylandWindowto aCWaylandWindow, which is incorrect for layer shells which areIWaylandWindowbut notCWaylandWindow. The popup doesn't actually need anything fromCWaylandWindowso changing the type doesn't change any behavior.Then making layer shells work is a simple change to call get popup on the layer shell after making the popup.