Guard the splash's activateApp() call for Windows - #2
Merged
Conversation
activateApp() is declared in platform/MacOverlay.h, which only compiles on Darwin. The permissions window's call was already inside a Q_OS_MACOS guard; the one added to showSplash() was not, so the Windows leg failed with C3861 while both macOS legs went green. Audited the other macOS-only symbols main.cpp touches — macTrashIcon and the two platform includes — and all of them are guarded. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
activateApp() is declared in platform/MacOverlay.h, which only compiles on Darwin. The permissions window's call was already inside a Q_OS_MACOS guard; the one added to showSplash() was not, so the Windows leg failed with C3861 while both macOS legs went green. Audited the other macOS-only symbols main.cpp touches — macTrashIcon and the two platform includes — and all of them are guarded.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com