Skip to content

Rename the HttpBody export to Body #2839

Closed
#2969
Closed
Rename the HttpBody export to Body#2839
#2969
Labels
A-bodyArea: body streaming.C-featureCategory: feature. This is adding a new feature.E-easyEffort: easy. A task that would be a great starting point for a new contributor.
Milestone
1.0 RC1

Description

@seanmonstar
seanmonstar
opened on May 20, 2022

When the concrete Body struct is removed, we can export the http_body::Body trait as just Body.

Activity

  1. seanmonstar
    added
    E-easyEffort: easy. A task that would be a great starting point for a new contributor.
    C-featureCategory: feature. This is adding a new feature.
    A-bodyArea: body streaming.
    on May 20, 2022
  2. seanmonstar
    added this to the 1.0 milestone on May 20, 2022
  3. seanmonstar
    added this to hyper 1.0on May 20, 2022

  4. yuri-potatoq commented on May 22, 2022

    @yuri-potatoq
    yuri-potatoq
    on May 22, 2022

    What would be the advantage in case of import both trait and struct?

  5. seanmonstar commented on May 22, 2022

    @seanmonstar
    seanmonstar
    on May 22, 2022
    MemberAuthor

    The struct will be removed, as detailed in #2345.

  6. seanmonstar
    moved this to Todo in hyper 1.0on Jun 15, 2022

  7. RajivTS commented on Aug 20, 2022

    @RajivTS
    RajivTS
    on Aug 20, 2022
    Contributor

    I am just starting up with Hyper so would like to work on this task (if that's ok). By renaming and exporting the http_body::Body trait as just Body, I assume you are talking about updating the following:

    hyper/src/body/mod.rs

    Lines 19 to 23 in 84f6ae7

    pub use http_body::Body as HttpBody;
    pub use http_body::SizeHint;
    pub use self::aggregate::aggregate;
    pub use self::body::{Body, Sender};

    But since the concrete Body type is already exported as Body, wouldn't that cause a conflict? Should I get rid of the concrete type export?

  8. seanmonstar commented on Aug 20, 2022

    @seanmonstar
    seanmonstar
    on Aug 20, 2022
    MemberAuthor

    Yes, we'd need to finish removing parts of Body, and renaming that. Then this one would be straightforward.

  9. RajivTS commented on Aug 20, 2022

    @RajivTS
    RajivTS
    on Aug 20, 2022
    Contributor

    Is there a separate task that I can work on to remove parts of Body?

  10. seanmonstar
    moved this from Todo to Blocked in hyper 1.0on Aug 22, 2022

  11. seanmonstar commented on Aug 25, 2022

    @seanmonstar
    seanmonstar
    on Aug 25, 2022
    MemberAuthor

    @RajivTS The top comment in #2345 includes a list of tasks, and I tried to put them in order of unblocking the next one. Some are linked to specific issues, we can make more of them issues too.

  12. Michael-J-Ward
    added 4 commits that reference this issue on Aug 25, 2022

    rename body to recv temporarily

    5261c37

    rename body to recv temporarily

    7039392

    rename body to recv temporarily

    da70a2e

    rename body to recv temporarily

    c21eebc
  13. seanmonstar
    added a commit that references this issue on Aug 26, 2022

    refactor(body): rename `Body` to `Recv` temporarily (#2966)

    7a41da5
  14. seanmonstar
    moved this from Blocked to Todo in hyper 1.0on Aug 26, 2022

  15. seanmonstar commented on Aug 26, 2022

    @seanmonstar
    seanmonstar
    on Aug 26, 2022
    MemberAuthor

    This is no longer blocked, since Body was renamed to Recv as a stop-gap (#2963).

  16. RajivTS
    added a commit that references this issue on Aug 28, 2022

    refactor(body): rename HttpBody export to Body

    0552706

  17. RajivTS commented on Aug 28, 2022

    @RajivTS
    RajivTS
    on Aug 28, 2022
    Contributor

    @seanmonstar Created PR to address this, would appreciate a review to understand if I missed something.

  18. RajivTS
    added a commit that references this issue on Aug 29, 2022

    refactor(body): rename HttpBody export to Body

    9be9fb7
  19. seanmonstar
    moved this from Todo to In Progress in hyper 1.0on Aug 29, 2022
  20. seanmonstar
    added a commit that references this issue on Aug 29, 2022

    refactor(body): rename HttpBody export to Body

    b2a8b3d
  21. seanmonstar
    closed this as completedin #2969on Aug 30, 2022
  22. Repository owner moved this from In Progress to Done in hyper 1.0on Aug 30, 2022
  23. seanmonstar
    added a commit that references this issue on Aug 30, 2022

    fest(body): rename `HttpBody` export to `Body` (#2969)

    031454e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-bodyArea: body streaming.C-featureCategory: feature. This is adding a new feature.E-easyEffort: easy. A task that would be a great starting point for a new contributor.

    Type

    No type

    Projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions