Re-enable tests for 0.13 #1848

Activity

1. seanmonstar

   added

   E-easyEffort: easy. A task that would be a great starting point for a new contributor.Effort: easy. A task that would be a great starting point for a new contributor.

   A-testsArea: tests.Area: tests.

   on Jul 9, 2019
2. seanmonstar

   added this to the 0.13 milestone on Jul 9, 2019
3. jakubadamw commented on Jul 23, 2019

   

   jakubadamw

   on Jul 23, 2019

   Contributor

   More actions

   The tests/client bit is done in #1881.
4. apiraino commented on Aug 27, 2019

   

   apiraino

   on Aug 27, 2019

   Last edited by apiraino

   More actions

   @seanmonstar or anyone else, could you pls also add an example on how to use the Service and MakeService trait?

   (I'm on Hyper 0.12 and having a hard time to figure that out. I'd be happy if for 0.13 that to be more discoverable).

   thanks 👍

   By the way: examples are of the essence for a library and I thank you so much for having written them! More of them, pls :-)

   EDIT: https://stackoverflow.com/questions/57371130/hyper-0-12-x-implementing-service-for-a-struct
5. Mathspy commented on Sep 7, 2019

   

   Mathspy

   on Sep 7, 2019

   More actions

   I think this is finally closed by #1882
6. weihanglo commented on Sep 9, 2019

   

   weihanglo

   on Sep 9, 2019

   Contributor

   More actions

   @Mathspy
   Not really. Some tests under src/client are still disabled. Most related to a new mock service implementations.

   👍React with 👍1Reacted by Mathspy
7. seanmonstar commented on Sep 11, 2019

   

   seanmonstar

   on Sep 11, 2019

   MemberAuthor

   More actions

   I'm going to close this, as almost all tests have been re-enabled. I've removed the warning about the missing tests in client/tests.rs, as re-writing them is rather tricky.

   🎉React with 🎉3Reacted by Mathspy, memoryruins and Weihang Lo
8. seanmonstar

   closed this as completedon Sep 11, 2019