Fix: drop the duplicated kernel_device_resources entry in the a2a3 sim list - #2240
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…m list `HOST_RUNTIME_SOURCES` in the a2a3 simulation host list named `common/platform/shared/host/kernel_device_resources.cpp` on two consecutive lines. The a5 simulation list and both onboard lists name it once, and CMake dedups a target's source list, so this changes no build output — it is a copy/paste slip from the integration commit, removed so the four lists read the same. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Superseded: this one-line fix is folded into the full refresh PR for the same base branch. |
1 participant
HOST_RUNTIME_SOURCESinsrc/a2a3/platform/sim/host/CMakeLists.txtnamescommon/platform/shared/host/kernel_device_resources.cppon two consecutivelines (53-54). The a5 simulation list and both onboard lists name it once.
CMake dedups a target's source list, so this produces no change in build
output — it is a copy/paste slip from the integration commit (#2216), removed
so the four platform lists read the same.
One line deleted; no behavior, no interface, no test change.
🤖 Generated with Claude Code