Skip to content

Docs: select the SDMA tests by marker in the testing skill's recipe - #1620

Merged
ChaoWao merged 1 commit into
hw-native-sys:mainfrom
ChaoWao:docs/testing-skill-sdma-recipe
Jul 31, 2026
Merged

ChaoWao merged 1 commit into
hw-native-sys:mainfrom
ChaoWao:docs/testing-skill-sdma-recipe

Conversation

@ChaoWao

@ChaoWao ChaoWao commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #1609 and #1617 — the same two defects, in the file whose stated purpose is reproducing CI.

1. The recipe contradicted the instruction three lines above it. The skill says quarantines "are markers on the tests, so mirror the sweep with -m "not sdma" rather than copying a path list" — and then the command block copied a path list:

pytest examples/a2a3/tensormap_and_ringbuffer/sdma_async_completion_demo \
       examples/a2a3/tensormap_and_ringbuffer/prefetch_async_demo

That is exactly the fragility #1609 removed from ci.yml. It is now pytest examples tests/st -m sdma — the same corpus and the same selector as the workflow's SDMA_TESTS, so the recipe cannot drift from the job it mirrors.

2. "Their own devices" is aarch64-only, in three places (prose, the quarantine table's "runs instead in" cell, and the command comment). Only the aarch64 branch gives the SDMA step task-submit --device auto --device-num 2; x86_64 has no task-submit and both steps use ${DEVICE_RANGE}. What holds on both is ordering — SDMA runs after the sweep, so no fault-injection case meets a device that has already provisioned SDMA. Same correction #1617 made to docs/ci.md.

Testing

  • Both recipes now match ci.yml verbatim in corpus and selector: sweep examples tests/st -m "not sdma", SDMA step examples tests/st -m sdma (ci.yml:627)
  • No hardcoded demo path remains in any command; the demo names survive only in the table's "Excludes" column, which describes what the marker covers rather than being copied
  • .claude/ is in NON_CODE, so every gated job should report skipping

The skill tells the reader, three lines above the command block, that
quarantines "are markers on the tests, so mirror the sweep with `-m "not sdma"`
rather than copying a path list". The block then copied a path list:

    pytest examples/a2a3/tensormap_and_ringbuffer/sdma_async_completion_demo \
           examples/a2a3/tensormap_and_ringbuffer/prefetch_async_demo

That is the fragility the marker replaced. A demo directory that moves leaves
this command silently running less than it claims — `pytest` on a path that
does not exist exits 4, but on a path that still exists while a *third* SDMA
test appears elsewhere it simply misses it, and CI's `-m sdma` would not. The
recipe is now `pytest examples tests/st -m sdma`, the same corpus and the same
selector the workflow uses, so the two cannot diverge.

The device claim is also corrected in three places. "Their own devices" is true
only on aarch64, where the SDMA step takes `task-submit --device auto
--device-num 2`; the x86_64 branch has no `task-submit` and both steps use the
same `${DEVICE_RANGE}`. What holds on both is **ordering** — the SDMA step runs
after the sweep, so no fault-injection case can meet a device that has already
provisioned SDMA. The prose, the quarantine table's "runs instead in" cell, and
the command comment now say that instead of asserting a device disjointness
that half the runners do not provide.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 31, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5713fbb5-b37e-452b-8de2-6e99aee05d82

📥 Commits

Reviewing files that changed from the base of the PR and between 47a65e1 and c317c0b.

📒 Files selected for processing (1)
  • .claude/skills/testing/SKILL.md

📝 Walkthrough

Walkthrough

The testing skill updates SDMA quarantine guidance. It documents marker-based exclusion from the general sweep and a dedicated post-sweep -m sdma run on two devices.

Changes

SDMA testing guidance

Layer / File(s) Summary
Marker-based SDMA execution
.claude/skills/testing/SKILL.md
The CI reproduction guidance replaces path-based SDMA selection with -m sdma and documents the dedicated two-device post-sweep execution.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A rabbit reads the markers bright,
SDMA hops beyond the sweep tonight.
Two devices wait in a later run,
The testing guide now matches CI’s plan.
“Binky!” says the rabbit, “The path is clear!”

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main documentation change: selecting SDMA tests by marker in the testing skill recipe.
Description check ✅ Passed The description directly explains both SDMA recipe corrections and their alignment with the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ChaoWao
ChaoWao merged commit f2a20ca into hw-native-sys:main Jul 31, 2026
14 checks passed
@ChaoWao
ChaoWao deleted the docs/testing-skill-sdma-recipe branch July 31, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant