[yanghaoran29]

Summary

• Stop smuggling the managed pto-isa checkout through os.environ["PTO_ISA_ROOT"] / $ENV{PTO_ISA_ROOT}. ensure_pto_isa_root() remains the pin source of truth; host CMake gets -DPTO_ISA_ROOT= (a2a3 always; a5 when an async overlay is ON).
• Drop ambient env exports in runtime_compiler, build_runtimes, conftest, scene_test, runtime_fatal_codes, and bake the path in l0_swimlane.
• Update docs/a5-sdma-overlay.md with the 2026-07-21 CANN 9.1.T500 repro (libopapi.so probe, 507018 / 0x715002a), mark [Code Health] Extend PTO-ISA build/run version guard to a5 onboard SDMA overlay (missed after #1179) #1351 done, and keep SDMA default OFF (no Option B on broken CANN).

Test plan

• pytest tests/ut/py/test_runtime_builder.py tests/ut/py/test_pto_isa.py (71 passed)
• CI green on this PR
• Spot-check: host cmake configure with overlay ON shows -DPTO_ISA_ROOT= and no reliance on ambient PTO_ISA_ROOT

Fixes #1403
Related to #1315

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 498c8cdd-f423-4f5f-9aef-979adb181f70

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The change removes PTO-ISA environment-variable transport, stores resolved paths in runtime state or metadata, passes paths to host CMake with -DPTO_ISA_ROOT, updates generated collection workflows, and revises related tests and a5 overlay documentation.

Changes

PTO-ISA path transport

Layer / File(s)	Summary
Runtime PTO-ISA resolution simpler_setup/runtime_compiler.py, simpler_setup/build_runtimes.py, conftest.py, simpler_setup/scene_test.py	Pinned PTO-ISA paths are retained in runtime state or metadata, while eager initialization no longer exports PTO_ISA_ROOT.
Host CMake path contract simpler_setup/runtime_builder.py, src/a2a3/.../CMakeLists.txt, src/a5/.../CMakeLists.txt, tests/ut/py/test_runtime_builder.py, tests/st/runtime_fatal_codes/test_runtime_fatal_codes.py	Host builds pass PTO_ISA_ROOT through CMake defines, and both host CMake files consume the CMake variable instead of the environment. Tests verify the define and remove test-side environment export.
Collection tooling and overlay procedure simpler_setup/tools/l0_swimlane.py, docs/a5-sdma-overlay.md	Generated collection scripts embed the resolved path, standalone task environments stop exporting it, and the a5 overlay documentation describes the revised gating and re-enable workflow.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related issues

• hw-native-sys/simpler#1315 — Covers the same a5 SDMA/URMA gating and PTO-ISA handling areas updated here.

Possibly related PRs

• hw-native-sys/simpler#1096 — Touches PTO-ISA resolution and runtime build metadata flow.
• hw-native-sys/simpler#1179 — Modifies a5 host CMake PTO-ISA include wiring.
• hw-native-sys/simpler#1404 — Updates the a5 async-SDMA PTO-ISA flow in overlapping runtime and CMake code.

Sequence Diagram(s)

sequenceDiagram
  participant RuntimeCompiler
  participant RuntimeBuilder
  participant HostCMake
  participant PTOISAHeaders
  RuntimeCompiler->>RuntimeBuilder: provide resolved PTO-ISA path
  RuntimeBuilder->>HostCMake: pass -DPTO_ISA_ROOT=path
  HostCMake->>PTOISAHeaders: use path/include
  HostCMake-->>RuntimeBuilder: configure host build

Loading

Poem

A rabbit hops where env vars flew,
With pinned paths passed cleanly through.
CMake finds the headers bright,
Tests guard the build just right.
SDMA notes now show the way—
No ambient roots to hide or stray.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 52.94% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: passing the pin-resolved PTO_ISA_ROOT by value instead of through the environment.
Description check	✅ Passed	The description is clearly aligned with the changeset and describes the env-to-argument refactor, docs updates, and test plan.
Linked Issues check	✅ Passed	The changes match #1403 by removing PTO_ISA_ROOT env transport, passing the resolved path explicitly to Python and CMake, and updating docs/tests.
Out of Scope Changes check	✅ Passed	No clearly unrelated code changes stand out; the extra doc detail and test updates still support the PTO_ISA_ROOT transport refactor and related overlay work.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request refactors how the PTO_ISA_ROOT path is propagated to CMake and downstream builds. Instead of exporting it as an ambient environment variable (os.environ["PTO_ISA_ROOT"]), it is now passed explicitly as a CMake define (-DPTO_ISA_ROOT=). This change is implemented across several setup scripts, test configurations, CMake files, and documentation. There are no review comments to assess, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.