You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using Command.Item exclusively (without grouping, etc.), the view fails to scroll to the first element even though the focus successfully shifts to it.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Hi, we hit this bug too: in a scrollable Command list with a heading-less group, navigating to the first item (e.g. Home) selects it but doesn't scroll it into view, because scrollSelectedIntoView returns early even when there is no heading to scroll.
I tested this PR's change against our repro on 2.18.1: without it the first item is never scrolled, with it it is. So it fixes the root cause for us, and we could drop our local workaround.
What's the current status? If anything is missing (tests, changeset, rebase), I can help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Command.Item exclusively (without grouping, etc.), the view fails to scroll to the first element even though the focus successfully shifts to it.
123.mov