Repository navigation
Compare version checks against plain release versions, not .dev0 - #8256
Open
qgallouedec wants to merge 1 commit into
Open
qgallouedec wants to merge 1 commit into
qgallouedec wants to merge 1 commit into
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version checks now compare against plain release versions:
Version("5.18.0"), notVersion("5.18.0.dev0"). A dev build of a version counts as the previous release.0.19.2.dev0becomes0.20.0: 0.19.2 was never released, and Resolve #2944: ensure_weight_tying respects config + improved tests peft#3171 first shipped in 0.20.0.5.23.0.dev0xfails intest_chat_template_utils.pyare left as is, Handle a missingcontentkey in the DeepSeek training chat templates #8228 removes them.Side effect on the dev-deps CI (peft main is
0.21.3.dev0): the LoRA MoE warning fires there, andtest_train_moe_with_peft_config_trains_all_mlp_layersis skipped, until peft 0.21.3 is released.Note
Low Risk
Test and version-guard tuning only; no training logic changes, though dev-deps CI may see different skips/warnings until matching releases ship.
Overview
Version gates across trainers,
chat_template_utils, and tests now compare against released version numbers (e.g.5.18.0,5.13.0,0.20.0,0.21.3) instead of*.dev0prerelease strings.Behavioral intent: a dev install like
5.18.0.dev0is treated as below5.18.0, so feature detection and skip/xfail conditions align with shipped releases rather than treating nightlymainas already past the gate.Notable threshold updates include PEFT
ensure_weight_tyingworkarounds (0.19.0–< 0.20.0, with comments noting the fix landed in 0.20.0), MoE LoRA dense/shared-layer warnings (peft < 0.21.3), transformers response-template support (>= 5.13.0), VLM assistant-only loss (>= 5.18.0), and GRPO tool parsing without jmespath (>= 5.13.0).Reviewed by Cursor Bugbot for commit 1da3185. Bugbot is set up for automated code reviews on this repo. Configure here.