Skip to content

Compare version checks against plain release versions, not .dev0 - #8256

Open
qgallouedec wants to merge 1 commit into
mainfrom
version-checks-no-dev
Open

qgallouedec wants to merge 1 commit into
mainfrom
version-checks-no-dev

Conversation

@qgallouedec

@qgallouedec qgallouedec commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Version checks now compare against plain release versions: Version("5.18.0"), not Version("5.18.0.dev0"). A dev build of a version counts as the previous release.

Side effect on the dev-deps CI (peft main is 0.21.3.dev0): the LoRA MoE warning fires there, and test_train_moe_with_peft_config_trains_all_mlp_layers is skipped, until peft 0.21.3 is released.


Note

Low Risk
Test and version-guard tuning only; no training logic changes, though dev-deps CI may see different skips/warnings until matching releases ship.

Overview
Version gates across trainers, chat_template_utils, and tests now compare against released version numbers (e.g. 5.18.0, 5.13.0, 0.20.0, 0.21.3) instead of *.dev0 prerelease strings.

Behavioral intent: a dev install like 5.18.0.dev0 is treated as below 5.18.0, so feature detection and skip/xfail conditions align with shipped releases rather than treating nightly main as already past the gate.

Notable threshold updates include PEFT ensure_weight_tying workarounds (0.19.0–< 0.20.0, with comments noting the fix landed in 0.20.0), MoE LoRA dense/shared-layer warnings (peft < 0.21.3), transformers response-template support (>= 5.13.0), VLM assistant-only loss (>= 5.18.0), and GRPO tool parsing without jmespath (>= 5.13.0).

Reviewed by Cursor Bugbot for commit 1da3185. Bugbot is set up for automated code reviews on this repo. Configure here.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-11T20:41:26.676078Z
We couldn’t complete this review. Comment @codex review to try again.
1da3185 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant