Skip to content

Modular conversion small fix - #48934

Merged
zucchini-nlp merged 2 commits into
huggingface:mainfrom
zucchini-nlp:modular-video-fix
Sep 18, 2026
Merged

zucchini-nlp merged 2 commits into
huggingface:mainfrom
zucchini-nlp:modular-video-fix

Conversation

@zucchini-nlp

@zucchini-nlp zucchini-nlp commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

CPU CI GPU run-slow

What does this PR do?

as per title

@github-actions

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: gemma4_unified

@@ -1185,6 +1185,8 @@ def replace_class_node(
"ImageProcessorPil": "image_processing_pil",
"VideoProcessor": "video_processing",
"VideoProcessorInitKwargs": "video_processing",
"VideoProcessorKwargs": "video_processing",
"ImageProcessorPilKwargs": "image_processing_pil",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't ask me why 😆

noticed in another internal release and if 100% honest, we should have never had two TypedDicts defined in each backend...
My long due plan to delete that and fix import/modular issues in centralized way

@zucchini-nlp
zucchini-nlp requested a review from vasqu September 18, 2026 13:08

@vasqu vasqu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks lol, what a weird interaction here. Feel like ive seen the vid processor kwargs stuff somewhere else at some point, might be worth to sanity check based on some regex pattern or claude/codex

@zucchini-nlp

Copy link
Copy Markdown
Member Author

i know right, i can't remember where but i defi made the fix at some point in some PR

@github-actions

Copy link
Copy Markdown
Contributor

CI recap

Dashboard: View test results in Grafana
Latest run: 35348309017
Result: success | Grafana metrics are not available yet.

@zucchini-nlp
zucchini-nlp added this pull request to the merge queue Sep 18, 2026
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Merged via the queue into huggingface:main with commit 95ad2ed Sep 18, 2026
40 checks passed
@zucchini-nlp
zucchini-nlp deleted the modular-video-fix branch September 18, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants