Repository navigation
PEFT x Dtensor-based TP integration - #48485
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
IIUC, we should wait for huggingface/peft#3614 to be merged and then check that the PEFT integration in Transformers works with this PR before merging, right? |
michaelbenayoun
requested review from
3outeille,
ArthurZucker and
BenjaminBossan
September 2, 2026 15:30
Member
Author
|
@BenjaminBossan yes works for me to do it the suggested order. |
| _maybe_shard_state_dict_for_tp(self, adapter_state_dict, adapter_name) | ||
| if has_tp_adapters and not is_peft_greater_or_equal("0.20.1", accept_dev=True): | ||
| raise ValueError( | ||
| "Loading a tensor-parallel PEFT adapter requires peft >= 0.20.1, please upgrade your peft " |
Member
There was a problem hiding this comment.
You can set the min version to 0.21.0. We will most likely not have a patch release at this point, and even if we did, the TP support wouldn't fit a patch release.
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PEFT integration was no up-to-date.
Working on support for the new DTensor-based API in the PEFT repo: huggingface/peft#3614.
cc @BenjaminBossan @3outeille