Repository navigation
Enable associative scan for Zamba - #48417
Closed
Marchematics wants to merge 2 commits into
Closed
Marchematics wants to merge 2 commits into
Marchematics wants to merge 2 commits into
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: zamba |
Contributor
CI recapDashboard: View test results in Grafana |
Collaborator
|
Thanks for the PR! The same change (a use_associative_scan config flag, wired into the Zamba mamba mixer) landed in #48331, so the Zamba part is already on main. The Japanese docs typo fix isn't related to this PR's topic, so feel free to send it separately as part of a broader docs cleanup. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the associative scan option in ZambaConfig and pass it through the Mamba mixer so compiled inference avoids the sequential fallback.
Test: python3 -m py_compile src/transformers/models/zamba/configuration_zamba.py src/transformers/models/zamba/modeling_zamba.py
AI assistance was used.