Repository navigation
[serge] Fix 2 integration tests for model cwm failing with import_or_config (other (2)) - #48414
Conversation
…or_config` (other (2))
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
1d8df38 to
2120509
Compare
2729a5e to
2120509
Compare
zucchini-nlp
left a comment
There was a problem hiding this comment.
It was moved under CwmAttention.layer_type which we can use instead, and fix the test assertion
I really don't know how to ask Serge to re-do it, so cc @tarekziade
We can't ask for new edits for now, but that's a good idea I will add that feature. In the interim, fixing within the branch |
|
run-slow: cwm |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: cwm |
|
This comment contains models: ["models/cwm"] |
CI recapDashboard: View test results in Grafana |
|
worked, left failures on that model are OOMs we will address in another patch |
…or_config` (other (2)) (huggingface#48414) * [serge] Fix 2 integration tests for model `cwm` failing with `import_or_config` (other (2)) * Use CwmAttention.layer_type instead of adding attention_type to the layer --------- Co-authored-by: serge[bot] <serge[bot]@users.noreply.github.com> Co-authored-by: Tarek Ziade <tarek@ziade.org>
Original CI failure
2 integration tests for modelcwmfailing withimport_or_config(other (2))tests/models/cwm/test_modeling_cwm.py::CwmIntegrationTest::test_cwm_integration[multi-gpu] (import_or_config, seen 7/7)CI traceback —
tests/models/cwm/test_modeling_cwm.py::CwmIntegrationTest::test_cwm_integrationWhere to watch it:
Relates to #48413
CwmIntegrationTest::test_cwm_integrationfails becauseCwmDecoderLayerhas noattention_typeattribute, yet the test assertslayer.attention_type == model.config.layer_types[i].Root cause:
CwmDecoderLayerinmodular_cwm.pyonly replaces the attention module; it never stores the per-layer attention type fromconfig.layer_types.Fix: set
self.attention_type = config.layer_types[layer_idx]inCwmDecoderLayer.__init__.make fix-repowill propagate this to the generatedmodeling_cwm.py.✅ Verified on GPU
serge ran the targeted
@slowtest(s) on a GPU runner and opened this PR only after they passed with this patch. Each targeted test was run 5× on both the pre-patch and patched trees to rule out flakiness — the result held on every run.This change was produced automatically by serge from a CI failure report. The patch was generated by an LLM and applied by serge; review before merging.
serge
v0.1.0· model:moonshotai/Kimi-K2.7-Code· 30 LLM turns · 30 tool calls · 47.8s · 784337 in / 10025 out tokens