Repository navigation
[serge] Fix 2 integration tests regressed by commit b9090ae58cda (PR #47096) - #48060
Conversation
|
[For maintainers] Suggested jobs to run (before merge) run-slow: cosmos3_omni |
CI recapDashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
IlyasMoutawwakil
left a comment
There was a problem hiding this comment.
LGTM ! thanks sergy 🫶
Investigation notes (manual bisect)Root cause confirmed via git bisect between Bisect result
ITEM0 ( Why b9090ae changed the outputPR #47096 refactored Side note on the CI traceThe assertion error shows ConclusionThis is not a bug — the new interpolation is more numerically accurate. The expected value update in this PR is correct and safe to merge. |
Original CI failure
2 integration tests regressed by commit b9090ae58cda (PR #47096)tests/models/cosmos3_omni/test_modeling_cosmos3_omni.py::Cosmos3OmniForConditionalGenerationIntegrationTest::test_small_model_integration_batched[multi-gpu] (output_mismatch, seen 5/7)CI traceback —
tests/models/cosmos3_omni/test_modeling_cosmos3_omni.py::Cosmos3OmniForConditionalGenerationIntegrationTest::test_small_model_integration_batchedWhere to watch it:
Relates to #48050
The
test_small_model_integration_batchedtest forCosmos3OmniForConditionalGenerationhas been failing since PR #47096 (commitb9090ae58cda) because the generated text for the second batched sample changed on CUDA: it now describes a "pink blanket" instead of a "pink couch" and ends with "They are lying on their sides, facing each".This is a test-expectation mismatch caused by a legitimate generation change, not a model bug. The actual decoded output is otherwise coherent and matches the existing XPU expectation for that sample.
This patch updates only the CUDA expected string for the second element in the batched test to the current generated output, leaving the first element and the XPU expectations untouched.
✅ Verified on GPU
serge ran the targeted
@slowtest(s) on a GPU runner and opened this PR only after they passed with this patch. Each targeted test was run 5× on both the pre-patch and patched trees to rule out flakiness — the result held on every run.Possibly related
Existing issues/PRs mentioning
test_small_model_integration_batched(keyword match — not verified to share a root cause):This change was produced automatically by serge from a CI failure report. The patch was generated by an LLM and applied by serge; review before merging.
serge
v0.1.0· model:moonshotai/Kimi-K2.7-Code· 27 LLM turns · 26 tool calls · 19.0s · 479987 in / 2733 out tokens