Repository navigation
Raise a clear error when a token is both forced and suppressed - #47511
Merged
Merged
Conversation
Closed
2 of 4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
CI recapDashboard: View test results in Grafana |
ArthurZucker
approved these changes
Sep 1, 2026
davidnichols-ops
added a commit
to davidnichols-ops/transformers
that referenced
this pull request
Sep 10, 2026
Resolve merge conflict with the suppress/forced-token overlap check (huggingface#47511): keep both checks, renumber the pad/eos overlap check to 2.8. Preserves the PR's final intent: warning-only via logger.warning_once (not added to minor_issues), multi-token eos lists only, and validate(strict=True) must not raise so save_pretrained keeps working for models that ship with pad_token_id in eos_token_id.
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small low priority contribution:
Using the same token in
forced_eos_token_id/forced_bos_token_idandsuppress_tokensis contradictory: at the forcing step every logit but the forced token is set to-inf, then the shared token is suppressed to-inftoo — leaving all logits-inf, producingnanprobabilities and the crypticRuntimeError: probability tensor contains inf/nan.GenerationConfig.validate()now rejects this with an actionable error. It fires only when every forced token is also suppressed (a guaranteed crash); partial overlap leaves a surviving forced token and is allowed. This also coversgenerate()(viavalidate()) andsave_pretrained.Before
After
Still allowed — partial overlap leaves a usable forced token, so no crash:
Closes #24099.